From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gTc10-0004ar-LE for guix-patches@gnu.org; Sun, 02 Dec 2018 19:23:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gTc0v-0002EK-3T for guix-patches@gnu.org; Sun, 02 Dec 2018 19:23:10 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54252) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gTc0s-0002DP-KF for guix-patches@gnu.org; Sun, 02 Dec 2018 19:23:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gTc0s-0003PY-G1 for guix-patches@gnu.org; Sun, 02 Dec 2018 19:23:02 -0500 Subject: bug#33572: [PATCH] Make Guile-JSON a required dependency. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sun, 2 Dec 2018 18:22:18 -0600 From: Eric Bavier Message-ID: <20181202182218.40049d39@centurylink.net> In-Reply-To: <875zwbk0zb.fsf@gnu.org> References: <20181202051822.8344-1-ericbavier@centurylink.net> <875zwbk0zb.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/cV7w=pa5/.t7H+g0a4YPmdW"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Cc: 33572-done@debbugs.gnu.org, Eric Bavier --Sig_/cV7w=pa5/.t7H+g0a4YPmdW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 02 Dec 2018 23:39:04 +0100 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello Eric, >=20 > ericbavier@centurylink.net skribis: >=20 > > From: Eric Bavier > > > > * README (Requirements): Remove "optional" verbiage. > > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional. > > (have_guile_json): Error if not "yes". > > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tes= ts > > unconditionally. > > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]:= Leave > > guile-json input. =20 >=20 > Could you include guix.texi changes along the lines of what Joshua > proposed on guix-devel? Done. > Otherwise LGTM, thanks! >=20 > Ludo=E2=80=99. Thanks for the review. Pushed in 6776af04d4b65c5a9a07784307a6abe395b6f480 `~Eric --Sig_/cV7w=pa5/.t7H+g0a4YPmdW Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlwEdzoACgkQ/XPKxxnT JWZf5Q//V4jxUudyZ6gDvkDYcAnzRbUQRWM305N4TEjt+dH1B6iG5NbaB0izJRSU LDFyLRN/Pj5RXv6dSNBfccm0rBmC0KyJaabDhwhk2qZ2xsCM2GLVTISQ1FJSVRLM Ol9PcRgfHab6yPpGhtkdWfmehw9LWkFQ6i66J0x7LBLfx0UPb4nskhyuqyOeGtyU a9l1upH1sWBwdx/x/7lFUlhqCAiAa7hnrK5m02z0iv/PhivRMGRjWWMcfOx5usku BAKVesnNcSkGAX96Ey1JV3RC9Zyz/ukU54FvvowJq7Km6NXYeXyDexG9fEv9Uc7g UodYQUUfUGvBoK3QGq2D+fX4poiWugKG1C+GFtsyAA6sSisUB+MDPs2z4c1GjcQl 1ad1oXKNOgv29UUjHf4BET+kmdCsL/goZdI9QNZ2LvKq+lPT2vd5gWK4pbQ5LDQR JzwFct646yC63sGuQM4E2/GckOIrMfdvrMWz3xiKSqpEK5uyg9NYCpsRHwWnKJX7 Rr1MpPyOXHlCsjBsTRItrAdqCXprXoEipL2YXIl+7E4x7uzifLFIU7wqcYxMX7+8 Lf1tyR/QRpSb+zZRld3hHkXhTp/G7/JPIodE7dihsb9prnh0B1wmTA9eieGq4S5U er9jhdcN8ufnXE+8br7/DaF+uxURV03KKLRDzMc1Rqb/IznuNbM= =QGQq -----END PGP SIGNATURE----- --Sig_/cV7w=pa5/.t7H+g0a4YPmdW--