From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gOxZ5-00075O-3I for guix-patches@gnu.org; Mon, 19 Nov 2018 23:23:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gOxZ0-0004ES-MC for guix-patches@gnu.org; Mon, 19 Nov 2018 23:23:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57287) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gOxYz-0004DV-Th for guix-patches@gnu.org; Mon, 19 Nov 2018 23:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gOxYz-0008Dq-Lr for guix-patches@gnu.org; Mon, 19 Nov 2018 23:23:01 -0500 Subject: [bug#33390] [PATCH 1/4] qtwebkit: Fix pri install directory. Resent-Message-ID: Date: Mon, 19 Nov 2018 22:22:44 -0600 From: Eric Bavier Message-ID: <20181119222244.26c47f9e@centurylink.net> In-Reply-To: <87h8gcso59.fsf@cbaines.net> References: <20181115041715.15993-1-ericbavier@centurylink.net> <20181115041715.15993-2-ericbavier@centurylink.net> <87h8gcso59.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/wo9YSRngf8Id3pA5JNG36Bm"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 33390@debbugs.gnu.org --Sig_/wo9YSRngf8Id3pA5JNG36Bm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Christopher, On Mon, 19 Nov 2018 22:22:58 +0000 Christopher Baines wrote: > ericbavier@centurylink.net writes: >=20 > > From: Eric Bavier > > > > This lets qmake find qtwebkit components, allowing packages like python= -pyqt > > to find qtwebkit and enable support. > > > > * gnu/packages/qt.scm (qtwebkit)[arguments]: Add "ECM_MKSPECS_INSTALL_D= IR" > > to #:configure-flags. Link with "--no-keep-memory". > > --- > > gnu/packages/qt.scm | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > > index d48769982..36f8aef69 100644 > > --- a/gnu/packages/qt.scm > > +++ b/gnu/packages/qt.scm > > @@ -10,6 +10,7 @@ > > ;;; Copyright =C2=A9 2017, 2018 Tobias Geerinckx-Rice > > ;;; Copyright =C2=A9 2018 Nicolas Goaziou > > ;;; Copyright =C2=A9 2018 Hartmut Goebel > > +;;; Copyright =C2=A9 2018 Eric Bavier > > ;;; > > ;;; This file is part of GNU Guix. > > ;;; > > @@ -2171,7 +2172,15 @@ different kinds of sliders, and much more.") > > #:configure-flags (list ;"-DENABLE_API_TESTS=3DTRUE" > > "-DPORT=3DQt" > > "-DUSE_LIBHYPHEN=3DOFF" > > - "-DUSE_SYSTEM_MALLOC=3DON"))) > > + "-DUSE_SYSTEM_MALLOC=3DON" > > + ;; XXX: relative dir installs to build = dir? > > + (string-append "-DECM_MKSPECS_INSTALL_D= IR=3D" > > + %output "/lib/qt5/mkspec= s/modules") > > + ;; Sacrifice a little speed in order to= link > > + ;; libraries and test executables in a > > + ;; reasonable amount of memory. > > + "-DCMAKE_SHARED_LINKER_FLAGS=3D-Wl,--no= -keep-memory" > > + "-DCMAKE_EXE_LINKER_FLAGS=3D-Wl,--no-ke= ep-memory"))) > > (home-page "https://www.webkit.org") > > (synopsis "Web browser engine and classes to render and interact w= ith web > > content") =20 >=20 > I've tested this, and this fixed the qtwebkit build for me, which > currently doesn't work on master. So I'm all for merging it. Thanks for testing it. I assume it was the linker flags that fixed the build on your machine? For clarity, I suppose that change should be moved to a separate patch. WDYT? `~Eric --Sig_/wo9YSRngf8Id3pA5JNG36Bm Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEoMXjUi7471xkzbfw/XPKxxnTJWYFAlvzjBUACgkQ/XPKxxnT JWZ0Ew//QlpbUrTd/Cbzs5WOKDW4b4E9k5PYFl012oOxbXGFn6ET4RaM9lhtcbMC L8Ztf3mH5JccKTLn76O0GgQxY5LzevAl8yvJM6rz2zRLpo4i+16LLlbnxJc2B4ya 7TyahIGWLvz41Zj2g4vT3glkbzaYOHq6IE3p/nDH9uV7v+h7vXgKrKo5oFh8mOSG SsVGSO0VBBzkoGohPCIJF7N74gOPDMN0BrJndDmRkBpmK8/H5RSECFQ3XFtqvHq4 /oyEP/LZkyj3Q9mthaOQTHsZeE0elxL82WPalRLw8hRCaXVpk5aqQt1IFYsWYfXK rKSs7fy/PAl0MxnRnA9/+r4qD/dnnE1hBiAeoV1CDRMPMaAkBkfcRB5coC2ctIux znQFekQ3Z/SVczRxU+bg5Texbd+LD0cfNbrdG6TaXy5FKlZp/DWUiQIUDO4egI/m UpuAnMVAg2P5FbBRvqtMfeQswUzFXF1twl+NzRSm9Y7/Brr8TZdCvtWP69cNAuNn jaUxYnLI33/XP1590hcj034o7lrRAaDPFmTqtN0WDEFk20c//7k+0MPuqKnEXtl9 MrybJj97cNTB4J4B+TZ3ID6DxhntMlFj9fuE3iL+saKVdfddNTiY63ktWI8e3LcA 19+LCtQJPU9pQb0ct4QB0hcKX9q4Og7PI/krvFuBM+5kqkW8nvU= =sYq+ -----END PGP SIGNATURE----- --Sig_/wo9YSRngf8Id3pA5JNG36Bm--