From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39735) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNMFL-0004eC-TQ for guix-patches@gnu.org; Thu, 15 Nov 2018 13:20:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNMFG-0007Jv-TO for guix-patches@gnu.org; Thu, 15 Nov 2018 13:20:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:50191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gNMFG-0007Jq-Ot for guix-patches@gnu.org; Thu, 15 Nov 2018 13:20:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gNMFG-0002Jf-G5 for guix-patches@gnu.org; Thu, 15 Nov 2018 13:20:02 -0500 Subject: [bug#33386] [PATCH 1/2] gnu: gajim: Add support for Guix packaged plugins. Resent-Message-ID: Date: Thu, 15 Nov 2018 19:19:03 +0100 From: Danny Milosavljevic Message-ID: <20181115191903.7f3db09b@scratchpost.org> In-Reply-To: <20181114195553.27293-1-clement@lassieur.org> References: <87d0r7e8ox.fsf@lassieur.org> <20181114195553.27293-1-clement@lassieur.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/sF9ST=3xGEk3Z5QJpJGZWLu"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Cc: 33386@debbugs.gnu.org --Sig_/sF9ST=3xGEk3Z5QJpJGZWLu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Cl=C3=A9ment, On Wed, 14 Nov 2018 20:55:52 +0100 Cl=C3=A9ment Lassieur wrote: >+ (add-after 'unpack 'add-plugin-dirs >+ (lambda _ >+ (substitute* "gajim/common/configpaths.py" >+ (("_paths\\['PLUGINS_USER'\\]") >+ (string-append >+ "_paths['PLUGINS_USER'],os.path.expanduser" >+ "('~/.guix-profile/share/gajim/plugins')"))) >+ #t)) [...] > + (pythonpath (string-append > + "$HOME/.guix-profile/lib/python" > + ,(version-major+minor > + (package-version python)) > + "/site-packages"))) Hmm, don't both of these hard-code one profile? I thought one can use any number of profiles - and this patch could definitely pick from the wrong one. Why isn't the PLUGINS_USER setting enough? Can't it be provided via environment variables? (set by the profile) Also, shouldn't PYTHONPATH already have been set by the profile? For me, it is set (to ~/.guix-profile/lib/python3.6/site-packages) when I log in. --Sig_/sF9ST=3xGEk3Z5QJpJGZWLu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlvtuJcACgkQ5xo1VCww uqX7Wwf/VcwanJSqE/4JWpJVnUf1b0BMPcHb1Ez7bBievsVcgZQztrObgVeilGjA NlH76K2RWaWILgXdW1FFlAXjikEgTJrfR5u4pahaz+cXPMkDcSffpNhfB3mbY8RJ +dmCLpJRGUOdMyWIp1xsmCBSsfDYHlJQFoTGnO1JayU8lVNi0qjO2dSycpkxbO4Y 5opD1FKTFC0HXudQWHnZNBELCkyOuZzD17n+LVPBZwySiHhVviY3EjvHLSYI7wxP 0I/e/1vMMEFwsb0x38CeUlBAxjxT2wwxWXvYe5Lx6ISEJXaEaznuyQEFEkXR1UW5 /R8fUaaxvC8sixpQUKc4x+jhtLeikg== =t6d8 -----END PGP SIGNATURE----- --Sig_/sF9ST=3xGEk3Z5QJpJGZWLu--