From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJzX3-0005rg-5q for guix-patches@gnu.org; Tue, 06 Nov 2018 06:28:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJzWn-0007Jt-OR for guix-patches@gnu.org; Tue, 06 Nov 2018 06:28:21 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJzWe-00073D-FA for guix-patches@gnu.org; Tue, 06 Nov 2018 06:28:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gJzWe-00014k-7B for guix-patches@gnu.org; Tue, 06 Nov 2018 06:28:04 -0500 Subject: [bug#33134] [PATCH 2/5] guix-install.sh: Add parse_args. Resent-Message-ID: Date: Tue, 6 Nov 2018 12:27:52 +0100 From: Danny Milosavljevic Message-ID: <20181106122752.49e1b484@scratchpost.org> In-Reply-To: <20181103011048.73864-1-s@ricketyspace.net> References: <20181024115443.GA1297@macbook41> <20181103011048.73864-1-s@ricketyspace.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/FA=tDjxk83+.l9p0+XbmEV="; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: rsiddharth Cc: 33134@debbugs.gnu.org --Sig_/FA=tDjxk83+.l9p0+XbmEV= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, > + # process -y / -n arg. > + export AUTO_YN=3D${1:1:1} > + if [ -z $AUTO_YN ]; then > + export AUTO_YN=3D"" > + fi Why "export" ? Now all the child processes get it, making their environment different from before. This makes parse_args have system-wide side effects. If we wanted to export it, we could do it explicitly after parse_args has been called. --Sig_/FA=tDjxk83+.l9p0+XbmEV= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlvhergACgkQ5xo1VCww uqUMDQgAid1V29fSxjaopH8+CyOwBheq0XEJzqk0HAhVMg7gvky7fCkeet0DX3BX COHyxsbauEdoRNzsfW7omBBpEZw0gejrqYhMLlnfcxFZX+1WJQNfDh4PzFepbxpn faBWF6mCz66cdwDivdE0zNmeJWjJ7bRP+B4NzjaD7cAaiilLKE9MJcHEajTEXxs2 8eKrC1LYUzO6e/QmM0K7UuS1oCzAgzkNcmQ0ZIOF0LDWZHwuDznbbvU+5tHaEwrN WGFyZvockvzoSqAVOZeE0RqaPtgqJ4ztCw7gIc35PhuiLIHSTh8FZBnZ56IozkFj 9FEL4LVi709SQ3cDO9zklt7YECe2pA== =7Yav -----END PGP SIGNATURE----- --Sig_/FA=tDjxk83+.l9p0+XbmEV=--