unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: rsiddharth <s@ricketyspace.net>
Cc: 33134@debbugs.gnu.org
Subject: [bug#33134] [PATCH 2/5] guix-install.sh: Add parse_args.
Date: Tue, 6 Nov 2018 12:27:52 +0100	[thread overview]
Message-ID: <20181106122752.49e1b484@scratchpost.org> (raw)
In-Reply-To: <20181103011048.73864-1-s@ricketyspace.net>

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi,

> +    # process -y / -n arg.
> +    export AUTO_YN=${1:1:1}
> +    if [ -z $AUTO_YN ]; then
> +        export AUTO_YN=""
> +    fi

Why "export" ? Now all the child processes get it, making their environment
different from before.  This makes parse_args have system-wide side effects.

If we wanted to export it, we could do it explicitly after parse_args has
been called.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-11-06 11:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24  0:15 [bug#33134] [PATCH 0/1] guix-install.sh: Add ability to run it non-interactively rsiddharth
2018-10-24  0:21 ` [bug#33134] [PATCH 1/1] guix-install.sh: Update welcome rsiddharth
2018-10-24 11:54 ` [bug#33134] [PATCH 0/1] guix-install.sh: Add ability to run it non-interactively Efraim Flashner
2018-10-24 13:24   ` Tobias Geerinckx-Rice
2018-10-24 13:27     ` Efraim Flashner
2018-11-03  1:10   ` [bug#33134] [PATCH 0/5] Add auto yes/no switch to guix-install.sh rsiddharth
2018-11-03  1:10   ` [bug#33134] [PATCH 1/5] guix-install.sh: Update welcome rsiddharth
2018-11-06 11:32     ` Danny Milosavljevic
2018-11-03  1:10   ` [bug#33134] [PATCH 2/5] guix-install.sh: Add parse_args rsiddharth
2018-11-06 11:27     ` Danny Milosavljevic [this message]
2018-11-03  1:10   ` [bug#33134] [PATCH 3/5] guix-install.sh: Update main rsiddharth
2018-11-06 11:28     ` Danny Milosavljevic
2018-11-03  1:11   ` [bug#33134] [PATCH 4/5] guix-install.sh: Update welcome rsiddharth
2018-11-03  1:11   ` [bug#33134] [PATCH 5/5] guix-install.sh: Update sys_authorize_build_farms rsiddharth
2018-11-06 11:31     ` Danny Milosavljevic
2018-11-09  4:13 ` [bug#33134] [PATCH 0/4] [Refactor 0] Add auto yes/no switch to guix-install.sh rsiddharth
2018-11-09  4:14   ` [bug#33134] [PATCH 1/4] guix-install.sh: Add parse_args rsiddharth
2018-11-09  4:15   ` [bug#33134] [PATCH 2/4] guix-install.sh: Update main rsiddharth
2018-11-09  4:15   ` [bug#33134] [PATCH 3/4] guix-install.sh: Update welcome rsiddharth
2018-11-09  4:15   ` [bug#33134] [PATCH 4/4] guix-install.sh: Update sys_authorize_build_farms rsiddharth
2021-07-13 12:01 ` bug#33134: [PATCH 0/1] guix-install.sh: Add ability to run it non-interactively Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181106122752.49e1b484@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=33134@debbugs.gnu.org \
    --cc=s@ricketyspace.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).