unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 33259@debbugs.gnu.org
Subject: [bug#33259] [PATCH 5/8] pack: Squashfs backend now honors '--localstatedir'.
Date: Tue, 6 Nov 2018 12:00:36 +0100	[thread overview]
Message-ID: <20181106120036.4e82c9a9@scratchpost.org> (raw)
In-Reply-To: <20181104221036.4776-5-ludo@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

> +                         (with-directory-excursion "squashfs-root"
> +                           (when (and (file-exists? (string-append bin
> +                                                                   "/guile"))
> +                                      (file-exists? "var/guix/db/db.sqlite")
> +                                      (string=? (string-append #$%bootstrap-guile "/bin")
> +                                                (pk 'binlink (readlink bin)))
> +                                      (string=? (string-append #$profile "/bin")
> +                                                (pk 'guilelink (readlink "bin"))))
> +                             (mkdir #$output))))))))

"pk" here on purpose?  Can't hurt in a test, I suppose...

LGTM!

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2018-11-06 11:01 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-04 22:01 [bug#33259] [PATCH 0/8] 'guix pack': Better '--localstatedir' handling and more tests Ludovic Courtès
2018-11-04 22:10 ` [bug#33259] [PATCH 1/8] pack: Move store database creation to a separate derivation Ludovic Courtès
2018-11-04 22:10   ` [bug#33259] [PATCH 2/8] pack: Import (guix store database) only when '--localstatedir' is passed Ludovic Courtès
2018-11-06 11:06     ` Danny Milosavljevic
2018-11-04 22:10   ` [bug#33259] [PATCH 3/8] install: Add 'install-database-and-gc-roots' Ludovic Courtès
2018-11-06 11:05     ` Danny Milosavljevic
2018-11-04 22:10   ` [bug#33259] [PATCH 4/8] pack: Docker backend now honors '--localstatedir' Ludovic Courtès
2018-11-06 10:57     ` Danny Milosavljevic
2018-11-06 14:45       ` Ludovic Courtès
2018-11-06 22:23         ` bug#33259: " Ludovic Courtès
2018-11-04 22:10   ` [bug#33259] [PATCH 5/8] pack: Squashfs " Ludovic Courtès
2018-11-06 11:00     ` Danny Milosavljevic [this message]
2018-11-06 14:44       ` Ludovic Courtès
2018-11-04 22:10   ` [bug#33259] [PATCH 6/8] pack: Add test for 'self-contained-tarball' with localstatedir Ludovic Courtès
2018-11-06 11:01     ` Danny Milosavljevic
2018-11-04 22:10   ` [bug#33259] [PATCH 7/8] store-copy: Canonicalize the mtime and permissions of the store copy Ludovic Courtès
2018-11-06 11:02     ` Danny Milosavljevic
2018-11-04 22:10   ` [bug#33259] [PATCH 8/8] pack: Add test for '--relocatable' Ludovic Courtès
2018-11-06 11:03     ` Danny Milosavljevic
2018-11-06 10:48   ` [bug#33259] [PATCH 1/8] pack: Move store database creation to a separate derivation Danny Milosavljevic
2018-11-06 14:43     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181106120036.4e82c9a9@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=33259@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).