From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43756)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gJyuw-0002jf-Qk
	for guix-patches@gnu.org; Tue, 06 Nov 2018 05:49:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gJyut-0004VG-Gl
	for guix-patches@gnu.org; Tue, 06 Nov 2018 05:49:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:60009)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gJyut-0004V0-DE
	for guix-patches@gnu.org; Tue, 06 Nov 2018 05:49:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gJyut-0008Ug-4t
	for guix-patches@gnu.org; Tue, 06 Nov 2018 05:49:03 -0500
Subject: [bug#33259] [PATCH 1/8] pack: Move store database creation to a
	separate derivation.
Resent-Message-ID: <handler.33259.B33259.154150129532583@debbugs.gnu.org>
Date: Tue, 6 Nov 2018 11:48:08 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20181106114808.6703f646@scratchpost.org>
In-Reply-To: <20181104221036.4776-1-ludo@gnu.org>
References: <20181104220130.4551-1-ludo@gnu.org>
	<20181104221036.4776-1-ludo@gnu.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	boundary="Sig_/llNDXFwcoGutx_2XIl=N9Dd";
	protocol="application/pgp-signature"
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 33259@debbugs.gnu.org

--Sig_/llNDXFwcoGutx_2XIl=N9Dd
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Ludo,

On Sun,  4 Nov 2018 23:10:29 +0100
Ludovic Court=C3=A8s <ludo@gnu.org> wrote:

> +  (when database
> +    (install-file database (scope "/var/guix/db/"))
> +    (chmod (scope "/var/guix/db/db.sqlite") #o644)

Hmm, is it guaranteed that the basename of DATABASE is "db.sqlite" ?
Sounds a little magical.

> +  (define database
>      (and localstatedir?
> -         (local-file (search-path %load-path
> -                                  "guix/store/schema.sql"))))
> +         (file-append (store-database (list profile))
> +                      "/db/db.sqlite")))

Ah okay.

Otherwise LGTM!

--Sig_/llNDXFwcoGutx_2XIl=N9Dd
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlvhcWgACgkQ5xo1VCww
uqU1EAgAhXpPG0KMyXp7Br2eG/CYvu/NwsfibvMdglKCd0EDG8dxQ90S5qz6Zfln
cnfzAqE2nBINWNNfusxMsxmFcFvEt3DLaX0cWtl69kO17iSQXgzcbQiyLXlo6moQ
+cV08nuaa5q76ZA/OVVISUs1l1HHVxAa0iSNYpDWxPoGiBNIwq0/5HLxkJRg6Y++
d+STOrsLMQbS2QO3x9gmA6h4Gbgs5M4q2IpAKQxR0MVmjh8ZsIVfWH4a5mPcDYKG
I0wyNbz+THx624QAtD+u/+5+M9Ni7ErJfLVarUd2sTZ7k4NnlMVaWg4LseSBTxnT
0PK8T/HR3KA1JZz9fiH8nxJYxX6MuQ==
=GSWV
-----END PGP SIGNATURE-----

--Sig_/llNDXFwcoGutx_2XIl=N9Dd--