From: Eric Bavier <ericbavier@centurylink.net>
To: 33284@debbugs.gnu.org
Subject: [bug#33284] [PATCH] python: Honor '--cores=...' in tests.
Date: Mon, 5 Nov 2018 20:23:44 -0600 [thread overview]
Message-ID: <20181105202344.0cab8e1e@centurylink.net> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 440 bytes --]
Hello Guix,
I noticed building 'python-minimal' that its tests seemed to have poor
memory performance, i.e. using *a lot* of RAM. I thought maybe
dropping --cores=... would help, but it did not; the tests use all
available cores by default. The attached patch fixes this issue,
though, the package still uses all cores while building some extension
libraries.
I suppose this patch would go to core-updates?
Cheers,
`~Eric
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-python-Honor-cores-.-in-tests.patch --]
[-- Type: text/x-patch, Size: 1001 bytes --]
From 076d2f7f32a51f90f85be3da836d208987e9c678 Mon Sep 17 00:00:00 2001
From: Eric Bavier <bavier@member.fsf.org>
Date: Thu, 1 Nov 2018 21:18:41 -0500
Subject: [PATCH] python: Honor '--cores=...' in tests.
* gnu/packages/python.scm (python-2.7)[arguments]: Add #:make-flags.
---
gnu/packages/python.scm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index fbb280224..9a8b9dfcf 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -206,6 +206,9 @@
"--enable-unicode=ucs4"
(string-append "LDFLAGS=-Wl,-rpath="
(assoc-ref %outputs "out") "/lib"))
+ ;; With no -j argument tests use all available cpus, so provide one.
+ #:make-flags
+ (list (format #f "EXTRATESTOPTS=-j~d" (parallel-job-count)))
#:modules ((ice-9 ftw) (ice-9 match)
(guix build utils) (guix build gnu-build-system))
--
2.19.1
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2018-11-06 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 2:23 Eric Bavier [this message]
2018-11-06 5:07 ` [bug#33284] [PATCH] python: Honor '--cores=...' in tests Mathieu Othacehe
2018-11-06 14:52 ` Eric Bavier
2018-11-06 16:00 ` Marius Bakke
2018-11-07 1:22 ` Eric Bavier
2018-11-07 2:18 ` Eric Bavier
2018-11-17 6:45 ` bug#33284: " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105202344.0cab8e1e@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=33284@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).