From: "Tomáš Čech" <sleep_walker@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 32727-done@debbugs.gnu.org
Subject: [bug#32727] [PATCH] gnu: Add telegram-purple.
Date: Sat, 27 Oct 2018 16:57:55 +0200 [thread overview]
Message-ID: <20181027145755.GC10836@doom> (raw)
In-Reply-To: <87h8h7a25k.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Sat, Oct 27, 2018 at 04:35:03PM +0200, Ludovic Courtès wrote:
>Hello Tomáš,
>
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> * gnu/packages/messaging.scm (telegram-purple): New variable.
>
>I’ve applied this patch but I ended up making substantial changes (patch
>attached), in particular:
>
> • Arrange to run “make install” so that all the files get installed
> (locales, icons, etc.) and not just the .so;
>
> • Adjust the test/loadtest.c so that it actually runs;
>
> • Arrange to keep the standard ‘configure’ phase rather than
> overriding it.
>
>The other changes are more cosmetic.
Thanks! You didn't have to do that by yourself, really. I would
eventually made it if you wouldn't accept that.
>
>Are we really more picky than openSuSE? :-)
Yes, you definitely are! And it is good that way, don't lower your
(our) standards!
Best regards,
S_W
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-27 14:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 11:45 [bug#32727] [PATCH] gnu: Add telegram-purple Tomáš Čech
2018-09-13 11:49 ` Tomáš Čech
2018-09-13 12:20 ` Tomáš Čech
2018-09-16 0:58 ` Leo Famulari
2018-10-02 9:48 ` Ludovic Courtès
2018-10-21 16:18 ` Tomáš Čech
2018-10-27 14:35 ` bug#32727: " Ludovic Courtès
2018-10-27 14:57 ` Tomáš Čech [this message]
2018-10-28 22:27 ` [bug#32727] " Ludovic Courtès
2018-09-13 16:39 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181027145755.GC10836@doom \
--to=sleep_walker@gnu.org \
--cc=32727-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).