unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 32948@debbugs.gnu.org
Subject: [bug#32948] [PATCH 08/21] gnu: Add java-w3c-svg.
Date: Tue, 9 Oct 2018 14:47:42 +0200	[thread overview]
Message-ID: <20181009144742.3c581b3d@alma-ubu> (raw)
In-Reply-To: <20181005155020.10239-8-dannym@scratchpost.org>

[-- Attachment #1: Type: text/plain, Size: 5255 bytes --]

On Fri,  5 Oct 2018 17:50:09 +0200
Danny Milosavljevic <dannym@scratchpost.org> wrote:

> * gnu/packages/batik.scm (java-w3c-svg-1.0): New variable.
> (java-w3c-svg): New variable.
> ---
>  gnu/packages/batik.scm | 68
> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68
> insertions(+)
> 
> diff --git a/gnu/packages/batik.scm b/gnu/packages/batik.scm
> index ccab88568..05ca234ea 100644
> --- a/gnu/packages/batik.scm
> +++ b/gnu/packages/batik.scm
> @@ -194,3 +194,71 @@ SAC is an interface for CSS parsers.")
>      (description "This package provides a SAC interface by the W3C.
>  SAC is an interface for CSS parsers.")
>      (license license:w3c)))
> +
> +(define-public java-w3c-svg-1.0
> +  (package
> +    (name "java-w3c-svg")
> +    (version "20010904")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "http://www.w3.org/TR/2001/REC-SVG-"
> version
> +                            "/java-binding.zip"))
> +        (sha256
> +         (base32
> +          "0gnxvx51bg6ijplf6l2q0i1m07101f7fickawshfygnsdjqfdnbp"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:jar-name "w3c-svg.jar"
> +       #:source-dir "."
> +       #:tests? #f ; No tests exist.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'unpack
> +           (lambda* (#:key source #:allow-other-keys)
> +             (invoke "unzip" source)))
> +         (add-after 'unpack 'patch-interface
> +           (lambda _
> +             ;; Make it compatible with batik.
> +             ;; This is equivalent to usingxml commons externals'
> +             ;; "externals" part from
> https://xerces.apache.org/mirrors.cgi
> +             (substitute* "SVGFEConvolveMatrixElement.java"
> +              (("public SVGAnimatedLength[ ]*getKernelUnitLength")
> +               "public SVGAnimatedNumber getKernelUnitLength"))
> +             (substitute* "SVGFEMorphologyElement.java"
> +              (("public SVGAnimatedLength[ ]*getRadius")
> +               "public SVGAnimatedNumber getRadius"))
> +             (call-with-output-file "EventListenerInitializer.java"
> +               (lambda (port)
> +                 (format port "
> +// License: http://www.apache.org/licenses/LICENSE-2.0
> +package org.w3c.dom.svg;
> +public interface EventListenerInitializer {
> +    public void initializeEventListeners(SVGDocument doc);
> +}
> +
> +")))
> +             #t)))))
> +    (propagated-inputs
> +     `(("java-w3c-smil" ,java-w3c-smil-3.0)))
> +    (native-inputs
> +     `(("unzip" ,unzip)))
> +    (home-page "https://www.w3.org/Style/CSS/SAC/")
> +    (synopsis "W3C SVG interface")
> +    (description "This package provides a SVG interface.")
> +    (license license:w3c)))
> +
> +(define-public java-w3c-svg
> +  (package
> +    (inherit java-w3c-svg-1.0)
> +    (version "20110816")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (string-append "http://www.w3.org/TR/2011/REC-SVG11-"
> version
> +                            "/java-binding.zip"))
> +        (sha256
> +         (base32
> +          "0jicqcrxav8ggs37amgvvwgc2f0qp1c5wns4rb2i3si83s2m09ns"))))
> +    (propagated-inputs
> +     `())))
> 
> 

This does not build on Hydra and locally.

https://hydra.gnu.org/build/3113818


starting phase `patch-interface'
Backtrace:
           6 (primitive-load "/gnu/store/rrz82jnhlq4lfkk5wpiidxb6mdw…")
In ice-9/eval.scm:
   191:35  5 (_ #f)
In srfi/srfi-1.scm:
    640:9  4 (for-each #<procedure 703740 at /gnu/store/ghwa6l2079l…> …)
In /gnu/store/ghwa6l2079l50ryzygybbkb8lhmm5hha-module-import/guix/build/gnu-build-system.scm:
   799:31  3 (_ _)
In ice-9/eval.scm:
    619:8  2 (_ #(#(#<directory (guile-user) 7cc140>) (#:inputs # …)))
In /gnu/store/ghwa6l2079l50ryzygybbkb8lhmm5hha-module-import/guix/build/utils.scm:
   636:30  1 (with-atomic-file-replacement "SVGFEConvolveMatrixElem…" …)
In unknown file:
           0 (stat "SVGFEConvolveMatrixElement.java" #<undefined>)

ERROR: In procedure stat:
In procedure stat: No such file or directory: "SVGFEConvolveMatrixElement.java"

Below is a fix.

Is there a reason you added the version number to the scheme-variable?
I thought that is done only when we have different versions of the same
package.

Björn



diff --git a/gnu/packages/batik.scm b/gnu/packages/batik.scm
index cdd1e4471..d8d70adcd 100644
--- a/gnu/packages/batik.scm
+++ b/gnu/packages/batik.scm
@@ -114,6 +114,7 @@ SAC is an interface for CSS parsers.")
              (invoke "unzip" source)))
          (add-after 'unpack 'patch-interface
            (lambda _
+             (chdir "org/w3c/dom/svg/")
              ;; Make it compatible with batik.
              ;; This is equivalent to usingxml commons externals'
              ;; "externals" part from https://xerces.apache.org/mirrors.cgi
@@ -134,7 +135,7 @@ public interface EventListenerInitializer {
 
 ")))
              #t)))))
-    (propagated-inputs
+    (inputs
      `(("java-w3c-smil" ,java-w3c-smil-3.0)))
     (native-inputs
      `(("unzip" ,unzip)))



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-10-09 12:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 15:44 [bug#32948] [PATCH 00/21] Add batik Danny Milosavljevic
2018-10-05 15:50 ` [bug#32948] [PATCH 01/21] gnu: Add java-batik-i18n Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 02/21] gnu: Add java-batik-constants Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 03/21] gnu: Add java-batik-util Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 04/21] gnu: Add java-batik-xml Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 05/21] gnu: Add java-batik-ext Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 06/21] gnu: Add java-w3c-smil Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 07/21] gnu: Add java-w3c-sac Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 08/21] gnu: Add java-w3c-svg Danny Milosavljevic
2018-10-09 12:47     ` Björn Höfling [this message]
2018-10-05 15:50   ` [bug#32948] [PATCH 09/21] gnu: Add java-xmlgraphics-commons Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 10/21] gnu: Add java-batik-css Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 11/21] gnu: Add java-batik-dom Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 12/21] gnu: Add java-batik-awt-util Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 13/21] gnu: Add java-batik-parser Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 14/21] gnu: Add java-batik-svg-dom Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 15/21] gnu: Add java-batik-anim Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 16/21] gnu: Add java-batik-gvt Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 17/21] gnu: Add java-batik-script Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 18/21] gnu: Add java-batik-bridge Danny Milosavljevic
2018-10-05 15:50   ` [bug#32948] [PATCH 19/21] gnu: Add java-batik-svggen Danny Milosavljevic
2018-10-05 15:54   ` [bug#32948] [PATCH 01/21] gnu: Add java-batik-i18n Danny Milosavljevic
2018-10-05 16:28   ` Julien Lepiller
2018-10-05 18:49     ` Danny Milosavljevic
2018-10-06 11:06       ` Julien Lepiller
2018-10-05 15:51 ` [bug#32948] [PATCH 20/21] gnu: Add java-batik-transcoder Danny Milosavljevic
2018-10-05 15:51   ` [bug#32948] [PATCH 21/21] gnu: Add batik Danny Milosavljevic
2018-10-05 16:37     ` Julien Lepiller
2024-02-21 16:54 ` bug#32948: close bug #32948 Steve George

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009144742.3c581b3d@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=32948@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).