From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g4rHj-0004Yd-IO for guix-patches@gnu.org; Tue, 25 Sep 2018 13:38:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g4rHe-0000dE-Px for guix-patches@gnu.org; Tue, 25 Sep 2018 13:38:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49723) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g4rHe-0000cu-LO for guix-patches@gnu.org; Tue, 25 Sep 2018 13:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g4rHe-0006P2-75 for guix-patches@gnu.org; Tue, 25 Sep 2018 13:38:02 -0400 Subject: [bug#32813] [PATCH 3/4] gnu: Add osm2pgsql. Resent-Message-ID: Date: Tue, 25 Sep 2018 19:37:40 +0200 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180925193740.0284e415@alma-ubu> In-Reply-To: <20180923204311.8086-3-julien@lepiller.eu> References: <20180923223952.7168c8e8@lepiller.eu> <20180923204311.8086-1-julien@lepiller.eu> <20180923204311.8086-3-julien@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/WD=a9my9J29M2DBbFI.4cyw"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 32813@debbugs.gnu.org --Sig_/WD=a9my9J29M2DBbFI.4cyw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 23 Sep 2018 22:43:10 +0200 Julien Lepiller wrote: > * gnu/packages/geo.scm (osm2pgsql): New variable. > --- > gnu/packages/geo.scm | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm > index 81bffcc88..efc68ea85 100644 > --- a/gnu/packages/geo.scm > +++ b/gnu/packages/geo.scm > @@ -824,3 +824,33 @@ delivered to any client.") > files and imports the data into PostgreSQL/PostGIS databases. It is > designed to create databases that are optimized for > rendering/tile/map-services.") (license license:asl2.0))) > + > +(define-public osm2pgsql > + (package > + (name "osm2pgsql") > + (version "0.96.0") [..] > + (license license:gpl2))) Hm.=20 The COPYING file says gpl2. The README is saying nothing about the license. A LICENSE file is missing. Most .cpp/.h files do not have a header and do not clarify it. But these 3 do: ./parse-osmium.cpp: *No copyright* GPL (v2 or later) ./parse-osmium.hpp: *No copyright* GPL (v2 or later) ./tests/test-options-projection.cpp: GPL (v2 or later) Is this (list gpl2 gpl2+) ?! Found more: ./contrib/protozero/LICENSE.from_folly: *No copyright* Apache License (v2.0) ./contrib/protozero/LICENSE.md: BSD 2-clause "Simplified" License ./contrib/libosmium/osmium/*: BSL Does it make sense/have you tried to unbundle protozero and libosmonium: https://github.com/mapbox/protozero https://github.com/osmcode/libosmium Either unbundle or add to copyright line. Missing import: #:use-module (gnu packages lua) Otherwise, LGTM Thanks, Bj=C3=B6rn --=20 Dipl.-Inf. Bj=C3=B6rn H=C3=B6fling Software Developer (GIS, Java) http://www.bjoernhoefling.de/ +49-176-666 875 06 USt-IdNr: DE275885245 --Sig_/WD=a9my9J29M2DBbFI.4cyw Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAluqcmUACgkQvyhstlk+X/0PwwCfRn7yDEjPhFlz6lTC7c1EPfSR qpQAnjIoPPs+iE1fLhF6TnMtFO8YdXrn =AF1g -----END PGP SIGNATURE----- --Sig_/WD=a9my9J29M2DBbFI.4cyw--