[bug#32813] [PATCH 2/4] gnu: Add imposm3.

["Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>]

[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]

On Sun, 23 Sep 2018 22:43:09 +0200
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/geo.scm (imposm3): New variable.
> ---
>  gnu/packages/geo.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/gnu/packages/geo.scm b/gnu/packages/geo.scm
> index e6aafff7d..81bffcc88 100644
> --- a/gnu/packages/geo.scm
> +++ b/gnu/packages/geo.scm
> @@ -790,3 +790,37 @@ location queries to be run in SQL.")
>  takes geospatial data and slices it into vector tiles that can be
> efficiently delivered to any client.")
>      (license license:expat)))
> +
> +(define-public imposm3
> +  (package
> +    (name "imposm3")
> +    (version "0.6.0-alpha.4")

Is there a reason you chose the -alpha.4 instead of 0.5.0?

[..]
> +    (home-page "http://imposm.org/")

Use https.


> +    (synopsis "OpenStreetMap importer for PostGIS.")
> +    (description "Imposm is an importer for OpenStreetMap data.  It
> reads PBF +files and imports the data into PostgreSQL/PostGIS
> databases.  It is designed +to create databases that are optimized
> for rendering/tile/map-services.")
> +    (license license:asl2.0)))

/pre-inst-env guix lint $REVIEW_PACKAGE
gnu/packages/geo.scm:798:2: imposm3@0.6.0-alpha.4: permanent redirect from http://imposm.org/ to https://imposm.org/
gnu/packages/geo.scm:825:14: imposm3@0.6.0-alpha.4: no period allowed at the end of the synopsis

As with tegola, there are some dependencies in the 'vendors' directory.
Either unbundle them or add their licenses to the license field.

This does not work too:
 ./pre-inst-env guix environment --ad-hoc imposm3 -- imposm  version
0.0.0-dev


Otherwise fine.

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]