From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g3sXe-0001i0-0X for guix-patches@gnu.org; Sat, 22 Sep 2018 20:46:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g3sAS-0003rn-PU for guix-patches@gnu.org; Sat, 22 Sep 2018 20:22:37 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g3sAK-0003iP-Dr for guix-patches@gnu.org; Sat, 22 Sep 2018 20:22:31 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g3mtq-0001Hd-Gg for guix-patches@gnu.org; Sat, 22 Sep 2018 14:45:02 -0400 Subject: bug#32768: [PATCH] gnu: go-1.11: Add New Version Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sat, 22 Sep 2018 14:44:18 -0400 From: Leo Famulari Message-ID: <20180922184418.GA32763@jasmine.lan> References: <877ejinqph.fsf@gmail.com> <20180919212032.GA6893@jasmine.lan> <8736u2oq23.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <8736u2oq23.fsf@gmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Katherine Cox-Buday Cc: 32768-done@debbugs.gnu.org --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 21, 2018 at 09:58:28AM -0500, Katherine Cox-Buday wrote: >=20 > > I tested that some basic packages build within the go-build-system > > using Go 1.11 (several need to be updated to support Go 1.11, > > however). >=20 > Great to hear. I didn't think to do that, thanks! It can be done per-package by setting '#:go ,go-1.11' in the arguments field of the package you'd like to test, or for the entire go-build-system like this: diff --git a/guix/build-system/go.scm b/guix/build-system/go.scm index cf9116327..80894677f 100644 --- a/guix/build-system/go.scm +++ b/guix/build-system/go.scm @@ -44,7 +44,7 @@ (define (default-go) ;; Lazily resolve the binding to avoid a circular dependency. (let ((go (resolve-interface '(gnu packages golang)))) - (module-ref go 'go))) + (module-ref go 'go-1.11))) =20 (define* (lower name #:key source inputs native-inputs outputs system target > > This phase is identical to the one that would be inherited from Go > > 1.10, > > right? >=20 > Yes, thanks! Removed. Great! Pushed as 21280a8cd805ace5f95cd2580b8a6ca1e25050d7 > As an aside, this workflow is new to me. I'd greatly appreciate any > pointers on convention if anyone has any. I hope I'm doing this > correctly :) > From 52199d74e7e417f6257b2bdf73b9982724183347 Mon Sep 17 00:00:00 2001 > In-Reply-To: <32768@debbugs.gnu.org> > References: <32768@debbugs.gnu.org> > From: Katherine Cox-Buday > Date: Fri, 21 Sep 2018 09:38:23 -0500 > Subject: [PATCH] Remove Unecessary Stage Replacement In general, I prefer to make a change like this locally, amend the original commit (I use `git add --patch && git commit --amend --verbose`), and then send a new version of the original patch. git-format-patch and git-send-email both take the --subject-prefix argument, so you can generate the new patch with, for example, '--subject-prefix=3Dv2'. Then the subject line of your patch or email is helpfully annotated: Subject: [v2] gnu: Add Go 1.11. But, for simple edits like this, or when there is only one patch, sending a diff on the original patch works, too. Please let us know if you have other workflow questions! --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlumjYEACgkQJkb6MLrK fwhKAhAArXVspfbDfb8WLzJeNiC/qVAPTEkQpDUx0+MmdtjJpYBnN+pz7rdBeSSg ICJg4uIaExDeSIfsbHkX1hXD69UhIMJWL8tR58P4zEvltWjK4WlH9fn0pFSiEI1p T0Yps+DjemtGJZMoL/Dy4wGpNSpKL0d9u7Vxk7jJpKJHfOG4EuvYD2WKE1q0oQ4K Bv90lhwwKekX/Mr+51xB0nDoYnBO6Jbd3tnQ1/th3W3uZhpKvAxjou+fOr9Ut2JV w34fj6kbBIOYRd68di5ThZkwR6A3iSFb+YYouFixirUw7Uj1hULJ/onKdfQyxeFS ZZ/zBZ+H8T98cGGuBWlKOYU41c2hfWdC2ON/fATaeETiFjFFIToFumzumX7vLORj fVBRlvz4E+3fSpk54mf+7JeymF8nrZVKfSXORieEGKVeOzBC0D4kAdZNsnBvFVyt aUI/uahNHN+uIg3hUMa9Ey+Jcde9RKR0wh2ATTnWd1yMd6n1aH7OHgwrllBsHjBc BAJEqXb3hLXwL41F/L7VlSuHLkAz8MUpefDKXqgerCVqlX3Zdzu4uOipRKIATYzz 0zHoPIf9r+Y7mpgz9RGYjGtQRKvxKPU+/ug1RvcBo3aE37AUIW/hQJIKeAfDcCj2 AJanhKt1tJ9F9Xvv+AQ2nfFjMBb2lnaD/QHPqru396zqf6yeb1c= =jXg+ -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--