From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41178) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fyfqB-0004o5-An for guix-patches@gnu.org; Sat, 08 Sep 2018 12:12:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fyfq8-00084G-5f for guix-patches@gnu.org; Sat, 08 Sep 2018 12:12:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fyfq8-00084A-1T for guix-patches@gnu.org; Sat, 08 Sep 2018 12:12:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fyfq5-0006gi-U3 for guix-patches@gnu.org; Sat, 08 Sep 2018 12:12:03 -0400 Subject: [bug#32634] RFC: Process build output Resent-Message-ID: Date: Sat, 8 Sep 2018 16:11:44 +0000 From: Nils Gillmann Message-ID: <20180908161143.aonygx4iqnj2zury@abyayala> References: <877ek1z3gg.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <877ek1z3gg.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 32634@debbugs.gnu.org Hi, Ricardo Wurmus transcribed 2.1K bytes: > Hi Guix, > > this patch set is a first draft to stylize (potentially confusing) build > output when using “guix package” and “guix build”. > > This is done by adding a soft port that matches on lines in the build > output and colorizes them (unless INSIDE_EMACS or NO_COLOR are set, or > when output is redirected). For “guix package” the default behaviour is So far I have one comment: Would it make sense to use 'GUIX_UI_NO_COLOR' instead? This makes it clear what it is for (use clear function names), and it does not impose using "no colors" in other terminal applications if you permanently export it. > to also hide all build output that does not announce progress (unless > “--verbose” is passed) and to let a spinner show progress instead. For > “guix build” all build output is still printed. > > Honestly, I’m not really happy with the results, but I think it’s enough > to start a discussion about where this should lead. > > One thing I don’t like is that I had to set the “print-build-trace?” > default option to be able to display what build is currently happening. > Unfortunately, for small derivations this leads to output like this: > > --8<---------------cut here---------------start------------->8--- > Building /gnu/store/2x5xmvimja0pbkvvr8rym91q0249ajiv-fonts-dir.drv - x86_64-linux > Built /gnu/store/2x5xmvimja0pbkvvr8rym91q0249ajiv-fonts-dir.drv > Building /gnu/store/diz3pmgrqibvp2pyvgh4wyr4nx5vlx0y-glib-schemas.drv - x86_64-linux > Built /gnu/store/diz3pmgrqibvp2pyvgh4wyr4nx5vlx0y-glib-schemas.drv > Building /gnu/store/ss70j6lf8xxiiykdys92iw92khx68ix9-info-dir.drv - x86_64-linux > Built /gnu/store/ss70j6lf8xxiiykdys92iw92khx68ix9-info-dir.drv > Building /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv - x86_64-linux > Built /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv > --8<---------------cut here---------------end--------------->8--- > > I would prefer: > > Building /gnu/store/rh92rslbj4x9abyna6lc11jqifbavx13-librsvg-2.40.20.drv … DONE > > or similar. > > I don’t know about whether the colours are any good; I think the bold > green is hard to read on a bright terminal, while the black is hard to > read on a dark terminal. > > Lastly: the spinner. It’s a bit boring, I think. > > What do you think? Is this a step in the right direction? > > -- > Ricardo > > > >