unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>
To: Christopher Baines <mail@cbaines.net>
Cc: 32370@debbugs.gnu.org
Subject: [bug#32370] [PATCH 2/4] gnu: Add ruby-oj.
Date: Tue, 7 Aug 2018 00:30:07 +0200	[thread overview]
Message-ID: <20180807003007.0b3769ef@alma-ubu> (raw)
In-Reply-To: <20180805144322.4705-2-mail@cbaines.net>

[-- Attachment #1: Type: text/plain, Size: 2598 bytes --]

On Sun,  5 Aug 2018 15:43:20 +0100
Christopher Baines <mail@cbaines.net> wrote:

> From: Ben Woodcroft <donttrustben@gmail.com>
> 
> * gnu/packages/ruby.scm (ruby-oj): New variable.
> 
> Signed-off-by: Christopher Baines <mail@cbaines.net>
> ---
>  gnu/packages/ruby.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index a06be3e26..508bbe8c3 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3161,6 +3161,42 @@ unacceptable HTML and/or CSS from a string.")
>      (home-page "https://github.com/rgrove/sanitize/")
>      (license license:expat)))
>  
> +(define-public ruby-oj
> +  (package
> +    (name "ruby-oj")
> +    (version "3.6.0")

3.6.5 is already available.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       ;; Version on rubygems.org does not contain Rakefile, so
> download from
> +       ;; GitHub instead.
> +       (uri (string-append "https://github.com/ohler55/oj/archive/v"
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1vhjkmnyllkiwpwqh6swbam826ch2vhrjqmbys2ki6wh48vzknlb"))))

I forgot: Is this checksum-stable or should we switch to 
git-fetch here?

> +    (build-system ruby-build-system)
> +    (arguments
> +     '(#:test-target "test_all"
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'disable-bundler
> +           (lambda _
> +             (substitute* "Rakefile"
> +               (("Bundler\\.with_clean_env") "1.times")
> +               (("bundle exec ") "")))))))
> +    (native-inputs
> +     `(("bundler" ,bundler)
> +       ("ruby-rspec" ,ruby-rspec)
> +       ("ruby-rake-compiler" ,ruby-rake-compiler)))
> +    (synopsis "JSON parser for Ruby optimized for speed")
> +    (description
> +     "Oj is a JSON parser and generator for Ruby, where the encoding
> and +decoding of JSON is implemented as a C extension to Ruby.")
> +    (home-page "https://www.ohler.com/oj")

I had trouble reaching that site over httpS. http was fine.
Is this permanent or temporary?
rubygems also has http as homepage.


> +    (license license:expat)))

./ext/oj/fast.c: BSD (3 clause)
./ext/oj/hash.c: BSD (3 clause)
./ext/oj/hash.h: BSD (3 clause)
./ext/oj/hash_test.c: BSD (3 clause)
and others

As above, guix build --rounds=2 -K complained, but diffoscope showed no dfference.

Björn

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2018-08-06 22:31 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-05 14:39 [bug#32370] [PATCH 0/4] A few Ruby related patches Christopher Baines
2018-08-05 14:43 ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-06 22:30     ` Björn Höfling [this message]
2018-08-28 20:38       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-06 22:31     ` Björn Höfling
2018-08-28 20:25       ` Christopher Baines
2018-08-05 14:43   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-08-06 22:30     ` Björn Höfling
2018-08-28 20:30       ` Christopher Baines
2018-08-29  4:53         ` Leo Famulari
2018-08-06 22:28   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-08-28 20:47     ` Christopher Baines
2018-08-28 20:33 ` Christopher Baines
2018-08-28 20:33   ` [bug#32370] [PATCH 2/4] gnu: Add ruby-oj Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 3/4] gnu: Enable tests for ruby-multi-json Christopher Baines
2018-08-28 20:34   ` [bug#32370] [PATCH 4/4] gnu: Add ruby-multi-test Christopher Baines
2018-09-11  6:26   ` [bug#32370] [PATCH 1/4] gnu: Add ruby-yajl-ruby Björn Höfling
2018-09-16 17:33     ` bug#32370: " Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180807003007.0b3769ef@alma-ubu \
    --to=bjoern.hoefling@bjoernhoefling.de \
    --cc=32370@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).