unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jan Nieuwenhuizen <janneke@gnu.org>
To: 32116@debbugs.gnu.org
Subject: [bug#32116] Allow bytevector as content of plain-file for binary data.
Date: Tue, 10 Jul 2018 19:41:26 +0200	[thread overview]
Message-ID: <20180710174128.6360-1-janneke@gnu.org> (raw)

Currently, plain-file does not handle binary content correctly.  As discussed
on IRC[0] I added bytevector support to plain-file.

This allows for using a package source directly from git, doing something like

--8<---------------cut here---------------start------------->8---
(define (command->bytevector command)
  (let ((port (apply open-pipe* OPEN_READ command)))
    (let ((output (get-bytevector-all port)))
      (close-port port)
      output)))

(define-public hello-git
  (package
    (name "hello")
    (version "git")
    (source (let* ((commit "stable-2.0")
                   (content (command->bytevector
                             `("git" "archive" "--format" "tar" "--prefix"
                               ,(string-append commit "/") ,commit)))
                   (file-name (string-append "hello-" commit)))
              (plain-file file-name content)))
    ...
    ))
--8<---------------cut here---------------end--------------->8---

Greetings,
janneke

[0] https://gnunet.org/bot/log/guix/2018-07-10#T1763807

             reply	other threads:[~2018-07-10 17:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-10 17:41 Jan Nieuwenhuizen [this message]
2018-07-10 17:41 ` [bug#32117] [PATCH 1/2] store: Add `binary-file' Jan Nieuwenhuizen
2018-07-11 22:09   ` [bug#32116] " Ludovic Courtès
2018-07-12  4:30     ` bug#32116: " Jan Nieuwenhuizen
2018-07-11 22:09   ` Ludovic Courtès
2018-07-10 17:41 ` [bug#32118] [PATCH 2/2] gexp: Allow bytevector as content of `plain-file' Jan Nieuwenhuizen
2018-07-11 22:11   ` [bug#32116] " Ludovic Courtès
2018-07-12  4:31     ` Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180710174128.6360-1-janneke@gnu.org \
    --to=janneke@gnu.org \
    --cc=32116@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).