From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMz9K-00087K-5v for guix-patches@gnu.org; Sun, 27 May 2018 13:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMz9G-0006z6-Nl for guix-patches@gnu.org; Sun, 27 May 2018 13:08:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:43273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMz9G-0006z0-K3 for guix-patches@gnu.org; Sun, 27 May 2018 13:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMz9G-0004iw-Eq for guix-patches@gnu.org; Sun, 27 May 2018 13:08:02 -0400 Subject: bug#31239: Make alsa find its plugins Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sun, 27 May 2018 19:07:26 +0200 From: Julien Lepiller Message-ID: <20180527190726.32ea8178@lepiller.eu> In-Reply-To: <20180517080143.06b1113a@scratchpost.org> References: <20180422191345.1836dc69@lepiller.eu> <20180517080143.06b1113a@scratchpost.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/7USZMM=2pOIgMYGpWDp.Ku0"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 31239-done@debbugs.gnu.org --Sig_/7USZMM=2pOIgMYGpWDp.Ku0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Le Thu, 17 May 2018 08:01:43 +0200, Danny Milosavljevic a =C3=A9crit : > Hi Julien, >=20 > good idea! >=20 > The indentation in the patch files is off (alsa-lib uses tabs in its > source code). >=20 > Also, what is > 0001-Add-support-for-a-ALSA_PLUGIN_DIR-environment-variab.patch > embedded in this patch for? Maybe for upstream? Nice :) >=20 > You already patch the individual files in alsa-lib. >=20 > Note: It would be possible to use >=20 > ++ char* plugdir =3D getenv("ALSA_PLUGIN_DIR") ?: ALSA_PLUGIN_DIR; >=20 > instead of >=20 > ++ char* plugdir =3D ALSA_PLUGIN_DIR; > ++ char* envplugdir =3D getenv("ALSA_PLUGIN_DIR"); > ++ if(envplugdir !=3D NULL) > ++ plugdir =3D envplugdir; >=20 > (especially since it's repeated multiple times) but maybe that's too > obscure. >=20 > So LGTM except for the indentation and extra patch file! Pushed as 2101cc3fb691f443b830fdf5f846ded5fa018739 on core-updates. --Sig_/7USZMM=2pOIgMYGpWDp.Ku0 Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtfrmKFtBNyiyoPrtQxEfRSAIagwFAlsK5c4ACgkQQxEfRSAI agwKLxAAnES3JvQ2FK2/4xTsyLmOo36vUG+hdk9N1+oxmuihQHXyErTyaDNWEiP3 dYVPY99+xoDPvcomeKQXd4NBVWjvwKi7VcluRZurV+Bk6VVZ3WhXKdaYKqcukot/ Txmt4fvZsHezqfs1yo4poxvy6aj/JG2cBH15UASNbEhQeGGJpu3eAG8U3mvVOP0d /1kqM3SPXMDby8vLHmAb+brj5Qrau4gouV5qdVpgMZyvx1+6HNqHqEknAJxqi747 NFm1fanxdDvob6SOQIYA/5B3HMtuYfvV6PPZBeakYywOYzuG2sOaVbwfdDSjDIzz h9fiIKShiUrIy+ylAKtw/L/lAr+2mw3OtJrSw96Ssnb1C1L/T064lqu8xKfdExde XxZsMYOBNPcvZe9R+WnyW4nAjtcdzLkzr9e/ZHI0qVZqC8fu8HcUm/kzB4feGz+a QNdp1HEEcdGAJq1fOMk+rZFgyAq33wHa2CjzMRTAEGvFPwo43zIbrUlvm8msjXz9 pKyCCIsVslPfTtpQWujmyfVIWCiflbJr2f1nz1yeXHZFCijo2aMibMYcnPXwWOeL gZLV1gPOPaZy/fEMK/x2u2Rlvf1GS2Zgx3PX2ylu77RiOtcL/8Z1xetjBc+r9zzr eiEEdYu0bRGan7k5WlhaJt4goLLJSDDLxg/HgX6ch5IpDK4i8Cs= =vklG -----END PGP SIGNATURE----- --Sig_/7USZMM=2pOIgMYGpWDp.Ku0--