From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMegc-0000p8-1V for guix-patches@gnu.org; Sat, 26 May 2018 15:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMegY-0002MU-Pj for guix-patches@gnu.org; Sat, 26 May 2018 15:17:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fMegY-0002MO-M4 for guix-patches@gnu.org; Sat, 26 May 2018 15:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fMegY-0002DM-1w for guix-patches@gnu.org; Sat, 26 May 2018 15:17:02 -0400 Subject: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests. Resent-Message-ID: Date: Sat, 26 May 2018 21:16:04 +0200 From: Danny Milosavljevic Message-ID: <20180526211604.72c336bf@scratchpost.org> In-Reply-To: <878t861df7.fsf@gnu.org> References: <20180518191247.18456-1-dannym@scratchpost.org> <878t861df7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/aGp7nls2nK=uk_ULlzXX__Q"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31520@debbugs.gnu.org --Sig_/aGp7nls2nK=uk_ULlzXX__Q Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludo, On Sat, 26 May 2018 20:26:20 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Why is it needed? That would need a comment. :-) dtc has Python bindings and we build them. The u-boot-tools tests use them (nothing else does). I'll add a comment. > Even better if we > can achieve the same effect without defining this search path. Sure, I guess. If you install dtc into your profile it won't work then tho= ugh. Also, do you think we should try to extract the Python bindings into its own package? > Also no need for the leading slash in =E2=80=98files=E2=80=99. Okay. > > + (add-after 'install 'check > > + (lambda* (#:key make-flags test-target #:allow-other-keys) > > + (apply invoke "make" "mrproper" make-flags) > > + (setenv "SDL_VIDEODRIVER" "dummy") > > + (setenv "PAGER" "cat") > > + (apply invoke "make" test-target make-flags) > > + (symlink "build-sandbox_spl" "sandbox") > > + (invoke "test/image/test-imagetools.sh")))))) =20 >=20 > Please return #t. invoke does :) We can add another one, though. --Sig_/aGp7nls2nK=uk_ULlzXX__Q Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlsJsnQACgkQ5xo1VCww uqVNegf+Popjs2XCAUE7BCQzqDfOssInjtOW4fGnNrjKFbBn+yt8dB5NwDjc2dnH 222vgR4NawFIXpEh0+sskxsQi1yQJRhGlVt9pyy/Ak1a33Sxh419WhpQpWmitLeA 8X/aywckcb1G7L/hux/huw1pavPOXc/7VsJBVCI4EDxWNLTv6In4/U5veJXczOST EQFop8ROTkn2e2Jwd4M4cWh5Qw3XQowy/BRggh8i8Z31Mykpc7Jq0bxuClFOR+Tm odkwxBuWQJGTo0N3lNnwGofvRQgxOBiV2ufpizK5bIuC77EAV5SzqZxY9dI/5a3c AVc9wkXpT3oZX3I53LeaSgt1WjbKPA== =AbRy -----END PGP SIGNATURE----- --Sig_/aGp7nls2nK=uk_ULlzXX__Q--