From: Danny Milosavljevic <dannym@scratchpost.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31520@debbugs.gnu.org
Subject: [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests.
Date: Sat, 26 May 2018 21:16:04 +0200 [thread overview]
Message-ID: <20180526211604.72c336bf@scratchpost.org> (raw)
In-Reply-To: <878t861df7.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1160 bytes --]
Hi Ludo,
On Sat, 26 May 2018 20:26:20 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> Why is it needed? That would need a comment. :-)
dtc has Python bindings and we build them.
The u-boot-tools tests use them (nothing else does).
I'll add a comment.
> Even better if we
> can achieve the same effect without defining this search path.
Sure, I guess. If you install dtc into your profile it won't work then though.
Also, do you think we should try to extract the Python bindings into its own
package?
> Also no need for the leading slash in ‘files’.
Okay.
> > + (add-after 'install 'check
> > + (lambda* (#:key make-flags test-target #:allow-other-keys)
> > + (apply invoke "make" "mrproper" make-flags)
> > + (setenv "SDL_VIDEODRIVER" "dummy")
> > + (setenv "PAGER" "cat")
> > + (apply invoke "make" test-target make-flags)
> > + (symlink "build-sandbox_spl" "sandbox")
> > + (invoke "test/image/test-imagetools.sh"))))))
>
> Please return #t.
invoke does :)
We can add another one, though.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-05-26 19:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 19:12 [bug#31520] [PATCH] gnu: u-boot-tools: Enable tests Danny Milosavljevic
2018-05-26 18:26 ` Ludovic Courtès
2018-05-26 19:16 ` Danny Milosavljevic [this message]
2018-05-27 13:10 ` Ludovic Courtès
2018-05-27 22:05 ` Danny Milosavljevic
2018-05-28 7:57 ` Ludovic Courtès
2018-05-28 21:52 ` bug#31520: " Danny Milosavljevic
2018-05-29 14:33 ` [bug#31520] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180526211604.72c336bf@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=31520@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).