From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fKoPm-0000S9-Re for guix-patches@gnu.org; Mon, 21 May 2018 13:16:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fKoPj-0008Ci-MS for guix-patches@gnu.org; Mon, 21 May 2018 13:16:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fKoPj-0008C4-Hr for guix-patches@gnu.org; Mon, 21 May 2018 13:16:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fKoPi-0004Gv-DV for guix-patches@gnu.org; Mon, 21 May 2018 13:16:03 -0400 Subject: [bug#31484] [PATCH] gnu: icu4c: Patch zoneinfo directory. Resent-Message-ID: Date: Mon, 21 May 2018 13:15:14 -0400 From: Leo Famulari Message-ID: <20180521171514.GA13182@jasmine.lan> References: <20180517125834.7417-1-mail@cbaines.net> <878t8fpfah.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline In-Reply-To: <878t8fpfah.fsf@gnu.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31484@debbugs.gnu.org --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 19, 2018 at 10:21:42PM +0200, Ludovic Court=C3=A8s wrote: > Hello, >=20 > Christopher Baines skribis: >=20 > > Replace the hardcoded /usr/share/zoneinfo file with a reference to the = tzdata > > package. > > > > * gnu/packages/icu4c.scm (icu4c)[inputs]: Add tzdata. > > [arguments]: Add a patch-zoneinfo-directory phase. Thanks for noticing this, Chris. > I wonder if icu4c should instead depend on =E2=80=98tzdata-for-tests=E2= =80=99, which is > changed less frequently to avoid full rebuilds? Maybe Leo can comment. tzdata-for-tests is meant to be used by packages that don't need current time zone info. Thus, "for test suites only". We added tzdata-for-tests to make it cheaper to update tzdata. If icu4c needs current time zone info, it should not use tzdata-for-tests. Chris, can you give more context about how icu4c uses time zone information? > I hope icu4c also honors the TZDIR environment variable, which would > allow users to have it refer to the latest version. Do you know if > that=E2=80=99s the case? Yeah, it would be great if icu4c could just use TZDIR, which would allow us to continue updating the time zones relatively frequently... if icu4c actually needs the time zone database. Already, we have problems keeping them up to date because too many packages depend on them, and that's a problem for Guix users (clocks will be wrong in some time zones). If we let icu4c depend on tzdata, then we will only be able to update the time zones during core-updates, which is not frequent enough. Currently, we can at least update tzdata on 'staging' braches. It indicates two general problems, IMO: 1) the lack of build farm capacity 2) it should be possible to update the time zone database without rebuilding packages (the packages should use TZDIR) I wonder what is done in Nixpkgs... --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlsC/qIACgkQJkb6MLrK fwj4cA//QU8BC1a43Y+JsuGAIRraab+0E5TwbzVYoIDq2TkEw0Nf8FCuN9l+60hy z5fbC7V6taUujSLa7TFPiXsuKl1/jsRwqEI+iSxvJb9SIekubkIC8K1r0B60kY86 c8tCjrJRpD+Me2fvWQ2KC+46y5eyKa1YKU8czFj179vs3nUyzuKfLn/APLmKt8nj lc3I4NpkSIg/Zgh8k0CmvZUqiLB80cKfPcvEOCLONOAIqfnBQjeXyr5Gy4wTbL2D V0ZVoW11xPUr060o75Qx/wXZVhPKd+vxzqCC2JdvWAQGgzeiNrDsdHTHbY+sCZ+t 2WSZt/tB/DF8+vOtTrg0zaTR/NPSqU4fux6goRZK4J4y5XU76aDjXvs5uy4/uNFC ik+kkR+EadjW/nSXjy1OtEruJx7/aMTAnXQOCdy3ptwW2t76B0KEhueQzkIg5PV9 qfA63nH4nVA1GLW6AL5pxdNh5c2Mm8cqKjVfawZ1rCaqEHImDYABD7QDwdoffDYH kQg5FeZjqslutWxnbage8CCrl4e3D8AsZDwOZwOzzATy3j48j3U4uHrITgJuNhHA UZW0Nsj2+6Ua0Ft6jsgqFtnSMAKVGf7ESbrwoRspNuYT9s/NeaT8S20i1HuDIOeX lertsTtcupPMjSwziAfQpa3sh4yPR2Xoh/O9ZH44h4zJe0/qZQY= =A0oP -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm--