From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50243) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fH5JO-0005CC-1R for guix-patches@gnu.org; Fri, 11 May 2018 06:30:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fH5JK-00051A-U7 for guix-patches@gnu.org; Fri, 11 May 2018 06:30:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fH5JK-000514-R7 for guix-patches@gnu.org; Fri, 11 May 2018 06:30:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fH5JK-0007Uy-FB for guix-patches@gnu.org; Fri, 11 May 2018 06:30:02 -0400 Subject: [bug#31404] Add installer support for u-boot imx6 boards. Resent-Message-ID: Date: Fri, 11 May 2018 12:29:26 +0200 From: Danny Milosavljevic Message-ID: <20180511122926.15ed71b7@scratchpost.org> In-Reply-To: <87h8nfwgfp.fsf@aikidev.net> References: <87h8nfwgfp.fsf@aikidev.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/2eCuK9CKYW5wN+Xtxvpe4Y1"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Vagrant Cascadian Cc: 31404@debbugs.gnu.org --Sig_/2eCuK9CKYW5wN+Xtxvpe4Y1 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Vagrant, On Thu, 10 May 2018 10:47:54 -0700 Vagrant Cascadian wrote: > Add support to install u-boot for wandboard and mx6cuboxi, and add > u-boot target and installer support for novena. >=20 > Tested using GuixSD on wandboard solo and novena. The mx6cuboxi target > uses the same device offsets, and worked with manual installation. Cool! > It should be noted that the offsets for installing u-boot.img on imx6 > targets conflict with a typical GPT partition table header; works fine > with dos partition table headers. I'm not sure what safeguards could be > added to detect that. This also may not be unique to imx6 targets > (e.g. pine64 u-boot/atf also has a similar issue). Yeah, and Allwinner A10, A20, R40 etc have the same problem. I've talked to parted upstream about it so that at least the new partition tables are not created in a stupid way - but movement is slow. > Also, the novena patch has a known flaw, in that it requires copying the > u-boot.img file to the first partition rather than writing it to a raw > offset on the mmc device. Yeah, I guess it's fine to use mtools in the installer. > Not sure how to handle that exactly, as partitioning is typically a > manual process in guixsd? Yeah, for a first step we could just check sanity (in this case check whether mcat failed or not). > If nothing else, merging only the wandboard and mx6cuboxi patches and > only including the u-boot target for novena might make sense. Another > option would be to patch novena to load u-boot.img from an offset rather > than a filesystem, though I doubt that will be accepted in u-boot > upstream. There are lots of boards which need that setup anyway - most notably x86_64 UEFI systems - so we have to handle the case anyway. I vote for using mtools. I applied your patches to guix master. --Sig_/2eCuK9CKYW5wN+Xtxvpe4Y1 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlr1cIYACgkQ5xo1VCww uqXVbAf/Wdz4ftscE6rBXPbppIz3ZAeBG+J7IcA8eJFHm2AAbE+PCARucRngewCW eYHc6i2opG++12uIevm6L4NG73EoNPPleM8sFS4g/1IrtF4ZHMI5Kpie48JIYGpv MjNSm88ODRCPJU9eGltYbS23lBo+yGSaGCYmzNtFujsFyx26n9Yz4YT1eynYwzuL oZHfS0gaYThUsGVXY38SBk4yg0gS8SETS8E08hfech2j/74NlevRnNg0RhiYfJCx Rgh5G1ujfU4yemwvW5LR5AKqemdXBVQU90Kn6J0+K1CFB3NgAwLbzarueXjCyNS6 EAHCGVbK2kN4thh7sqSlMlR7sXRYnw== =cxsL -----END PGP SIGNATURE----- --Sig_/2eCuK9CKYW5wN+Xtxvpe4Y1--