unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: 31393@debbugs.gnu.org
Subject: [bug#31393] [PATCH 0/4] Add android-fastboot and rename packages.
Date: Wed, 9 May 2018 22:53:23 +0200	[thread overview]
Message-ID: <20180509225323.6678fe71@lepiller.eu> (raw)
In-Reply-To: <20180509203947.10746-1-dannym@scratchpost.org>



Le Wed,  9 May 2018 22:39:47 +0200,
Danny Milosavljevic <dannym@scratchpost.org> a écrit :

> Danny Milosavljevic (4):
>   gnu: Add android-fastboot.
>   gnu: Rename "liblog" to "android-liblog".
>   gnu: Rename "libbase" to "android-libbase".
>   gnu: Rename "libcutils" to "android-libcutils".
> 
>  gnu/packages/android.scm | 96
> ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 80
> insertions(+), 16 deletions(-)

I haven't tested your patches, but if they work, LGTM!

Could you simply add a comment to explain why you don't run tests (I
guess there aren't any). Also, I'm not sure about the name of the
android-fastboot package. Since it provides the fastboot command, I
think the convention is to call it fastboot, like adb is not
android-adb.

  parent reply	other threads:[~2018-05-09 20:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 20:39 [bug#31393] [PATCH 0/4] Add android-fastboot and rename packages Danny Milosavljevic
2018-05-09 20:41 ` [bug#31393] [PATCH 1/4] gnu: Add android-fastboot Danny Milosavljevic
2018-05-09 20:41   ` [bug#31393] [PATCH 2/4] gnu: Rename "liblog" to "android-liblog" Danny Milosavljevic
2018-05-09 20:41   ` [bug#31393] [PATCH 3/4] gnu: Rename "libbase" to "android-libbase" Danny Milosavljevic
2018-05-09 20:41   ` [bug#31393] [PATCH 4/4] gnu: Rename "libcutils" to "android-libcutils" Danny Milosavljevic
2018-05-09 20:53 ` Julien Lepiller [this message]
2018-05-10  0:52   ` bug#31393: [PATCH 0/4] Add android-fastboot and rename packages Danny Milosavljevic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509225323.6678fe71@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=31393@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).