From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44746) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFljy-0005KF-9b for guix-patches@gnu.org; Mon, 07 May 2018 15:24:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFlju-00031M-9T for guix-patches@gnu.org; Mon, 07 May 2018 15:24:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFlju-00031H-6T for guix-patches@gnu.org; Mon, 07 May 2018 15:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFlju-0001bZ-0A for guix-patches@gnu.org; Mon, 07 May 2018 15:24:02 -0400 Subject: [bug#31333] [PATCH 22/22] gnu: Add groovy. Resent-Message-ID: Date: Mon, 7 May 2018 21:23:00 +0200 From: Danny Milosavljevic Message-ID: <20180507212300.04075c3e@scratchpost.org> In-Reply-To: <20180501154449.3531-22-julien@lepiller.eu> References: <20180501174136.1c411b1a@lepiller.eu> <20180501154449.3531-1-julien@lepiller.eu> <20180501154449.3531-22-julien@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/j2010TFuTd8xDRbQFv9wsj2"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 31333@debbugs.gnu.org --Sig_/j2010TFuTd8xDRbQFv9wsj2 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable > + ;; Groovy uses class loading. It's not enough to put th= e class > + ;; in the loader's classpath, as it causes breakages: > + ;; the compiler would give this error: > + ;; "Prohibited package name: java.lang" It might make sense to ask upstream about that. > + ;; antlr.jar is present twice in antlr2. Symlink doesn= 't like > + ;; it, so we symlink it here. Why is it present twice? Is it useful? So this package uses an union in order to avoid classloader problems. Fine= , but I wonder whether the problem is now merely hidden. Anyway, LGTM for now (for this version) ! --Sig_/j2010TFuTd8xDRbQFv9wsj2 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlrwp5QACgkQ5xo1VCww uqUHjgf8Du5Ngp6aiXog3E+sW4pcLM7AOIMyxKRS54m69NOfNEULQ4YqhpSxTbY/ se4ahLJqijpI8aanAoSjgr8aYhTo4dBhKPovfGAB9tfex9iOf9dtK7DCVU3wv7ma Am6aSZiPDPGN/CT2huWWN+w1ym/CZ+Tfy3IQvefDRpMEbn11cqvgu/DT+Y/67URq Mp+XaPoZxXIexzTeFeC4rPi3Qca3A4HajeUzlrGjuWxDbGnBV6jCxHw98vwJRNR8 DuPYxORUU/fAK0Cyox79Ntn5i9KfES3DJ0hRvBSYTsYdhuxp3rN5RW7FiXP1K5od G8UvbfrGNnzx4bexpsULNG10BwW9+g== =bmwv -----END PGP SIGNATURE----- --Sig_/j2010TFuTd8xDRbQFv9wsj2--