From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFkPi-0004Vr-4a for guix-patches@gnu.org; Mon, 07 May 2018 13:59:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFkPe-0008L7-Vm for guix-patches@gnu.org; Mon, 07 May 2018 13:59:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:45160) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFkPe-0008Kp-TT for guix-patches@gnu.org; Mon, 07 May 2018 13:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fFkPe-00060P-D6 for guix-patches@gnu.org; Mon, 07 May 2018 13:59:02 -0400 Subject: [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap. Resent-Message-ID: Date: Mon, 7 May 2018 19:58:53 +0200 From: Danny Milosavljevic Message-ID: <20180507195853.14b363aa@scratchpost.org> In-Reply-To: <20180501154449.3531-1-julien@lepiller.eu> References: <20180501174136.1c411b1a@lepiller.eu> <20180501154449.3531-1-julien@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/ZQX.ejdzVz_6_OjyQZ0t/q7"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 31333@debbugs.gnu.org --Sig_/ZQX.ejdzVz_6_OjyQZ0t/q7 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Julien, On Tue, 1 May 2018 17:44:28 +0200 Julien Lepiller wrote: > + %D%/packages/patches/groovy-Add-exceptionutilsgenerator.patch \ Capital letter? Ok I guess, just uncommon. > + (uri (string-append "https://github.com/apache/groovy/arch= ive/GROOVY_" > + (string-map (lambda (x) (if (eq? x #\.= ) #\_ x)) version) > + ".tar.gz")) Hmm, is testing using "eq?" safe? I'd prefer "char=3D?". Even more, I'd p= refer using (match ...). > + (license (list license:gpl2 > + license:cddl1.1)))) Does that mean "AND" or "OR"? Please add a comment. > diff --git a/gnu/packages/patches/groovy-Add-exceptionutilsgenerator.patc= h b/gnu/packages/patches/groovy-Add-exceptionutilsgenerator.patch > new file mode 100644 > index 000000000..3c81f28cf > --- /dev/null > +++ b/gnu/packages/patches/groovy-Add-exceptionutilsgenerator.patch > @@ -0,0 +1,96 @@ > +From 3dbdc68093e90f0ef9b77b70490d8e0b1dcfbf8f Mon Sep 17 00:00:00 2001 > +From: Julien Lepiller > +Date: Sun, 17 Sep 2017 21:08:45 +0200 > +Subject: [PATCH] Add ExceptionUtilsGenerator.java from previous versions > + > +This is replaced by a gradle task, but gradle depends on groovy, so we > +need so way to generate the file without gradle. It might make sense to add a comment which version exactly this was copied = from. --Sig_/ZQX.ejdzVz_6_OjyQZ0t/q7 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlrwk90ACgkQ5xo1VCww uqVAEQf+MktXIew9NbQ0b3gSzeVO089oNNkCA3QSDYBfOeYvvkelSPDRBKltmvHA tVM822Vs9ilNCQxIAuaoBuDCYnhqZNcvj8rsPA25IS6XbWoIemvjLwaH6xJ95xGm FVeYxnW5UNzT1v0qIr6LEKANz5dzrJnPp54oeYNGeoeOYpKSHZc8T+47kvc8hlKn 6hQquWg71rhOQEaI5cDQO63V9Z+pDKbjw+CUAvqMHcve9zsLERhd6pq3TRuT00Ka o9YRRb7Rc0KCeDuZwAxhL3Ug3U13GrgfsMFEidFu/8qwCs10UHPzYDEMDik/49FR S42d0wfWv8xEfoqqK13mEwfiVVg89w== =fgkN -----END PGP SIGNATURE----- --Sig_/ZQX.ejdzVz_6_OjyQZ0t/q7--