From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDwgc-0005iU-9O for guix-patches@gnu.org; Wed, 02 May 2018 14:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDwgY-0002gD-Uv for guix-patches@gnu.org; Wed, 02 May 2018 14:41:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:39413) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDwgY-0002fy-PT for guix-patches@gnu.org; Wed, 02 May 2018 14:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fDwgY-0008Md-I5 for guix-patches@gnu.org; Wed, 02 May 2018 14:41:02 -0400 Subject: [bug#31331] [PATCH 1/2] gnu: Add bitlbee-discord. Resent-Message-ID: Date: Wed, 2 May 2018 18:41:12 +0000 From: Nils Gillmann Message-ID: <20180502184112.fi7dtxv2lzz3rxqi@abyayala> References: <20180501120535.13961-1-contact@parouby.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180501120535.13961-1-contact@parouby.fr> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre-Antoine Rouby Cc: 31331@debbugs.gnu.org Hi Pierre-Antoine, this package definition is promising but needs some last tweaks. I did not build it so far. Pierre-Antoine Rouby transcribed 3.3K bytes: > * gnu/packages/messaging.scm (bitlbee-discord): New variable. > (bitlbee): Add 'install-lib' phase. > --- > gnu/packages/messaging.scm | 50 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm > index fd1c330ce..d6bd588cb 100644 > --- a/gnu/packages/messaging.scm > +++ b/gnu/packages/messaging.scm > @@ -14,6 +14,7 @@ > ;;; Copyright © 2017 Theodoros Foradis > ;;; Copyright © 2017 Rutger Helling > ;;; Copyright © 2018 Leo Famulari > +;;; Copyright © 2018 Pierre-Antoine Rouby > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -181,6 +182,9 @@ end-to-end encryption.") > (add-after 'install 'install-etc > (lambda* (#:key (make-flags '()) #:allow-other-keys) > (zero? (apply system* "make" "install-etc" make-flags)))) > + (add-after 'install-etc 'install-lib > + (lambda* (#:key (make-flags '()) #:allow-other-keys) > + (zero? (apply system* "make" "install-dev" make-flags)))) > (replace 'configure > ;; bitlbee's configure script does not tolerate many of the > ;; variable settings that Guix would pass to it. > @@ -199,6 +203,52 @@ identi.ca and status.net).") > (home-page "http://www.bitlbee.org/") > (license (list license:gpl2+ license:bsd-2)))) > > +(define-public bitlbee-discord > + (package > + (name "bitlbee-discord") > + (version "0.4.1") > + (source (origin > + (method url-fetch) > + (uri > + (string-append > + "https://github.com/sm00th/bitlbee-discord/" > + "archive/" version ".tar.gz")) Nitpick, I would write it like: + (uri + (string-append "https://github.com/sm00th/bitlbee-discord/" + "archive/" version ".tar.gz")) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1bwqxlg6fwj3749y7w69n9jwsdzf5nl9xqiszbpv9k8x1422i1y1")))) > + (build-system gnu-build-system) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (invoke "sh" "autogen.sh"))) > + (add-before 'configure 'bash-path > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (substitute* "configure" > + (("\\$SHELL") (string-append (assoc-ref inputs "bash") > + "/bin/sh"))))) Is the configure.ac in this case special, or why doesn't it pick our SHELL that is already in the environment of the build chroot? > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (invoke "./configure" > + (string-append "--with-plugindir=" > + (assoc-ref outputs "out") > + "/lib/bitlbee/"))))))) > + (inputs `(("glib" ,glib))) > + (native-inputs `(("pkg-config" ,pkg-config) > + ("autoconf" ,autoconf) > + ("automake" ,automake) > + ("texinfo" ,texinfo) > + ("libtool" ,libtool) > + ("bitlbee" ,bitlbee) Does the buildsystem of bitlbee-discord check for bitlbee, or why is this required? > + ("bash" ,bash))) > + (synopsis "IRC to instant messaging gateway discord plugin") It's a bitlbee plugin, how about: "Discord plugin for Bitlbee" > + (description "This package is plugin for bitlbee IRC to other messaging > +gateway.") You could write: "Bitblee-discord is a plugin for Bitlbee which provides access to servers running the Discord protocol" I'm not very well informed about Discord, so other people might know more. > + (home-page "http://www.bitlbee.org/") Here we use either the homepage, and if it doesn't exist we link to a webview of the sourcecode or its directory on an httpd where the source is, in this case you'd use "https://github.com/sm00th/bitlbee-discord/" > + (license license:gpl2+))) > + > (define-public hexchat > (package > (name "hexchat") > -- > 2.17.0 > > > >