[bug#31252] [PATCH] gnu: Add Ranger.

[bug#31252] [PATCH] gnu: Add Ranger.

[Eric Bavier]

Hello Guix,

I think this package works, but I'm not much of a ranger user, so if
someone would like to give it a test, that would be appreciated.

Also, suggestions for a better module location are appreciated. :)

-- 
`~Eric


From 03abb95c7e551ea45d0742bf72cb78e5f0ce210e Mon Sep 17 00:00:00 2001
From: Eric Bavier <ericbavier@centurylink.net>
Date: Tue, 24 Apr 2018 18:44:38 -0500
Subject: [PATCH] gnu: Add Ranger.
To: guix-patches@gnu.org

From: Eric Bavier <bavier@member.fsf.org>

* gnu/packages/disk.scm (ranger): New variable.
---
 gnu/packages/disk.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/disk.scm b/gnu/packages/disk.scm
index 595000bf8..a36273a01 100644
--- a/gnu/packages/disk.scm
+++ b/gnu/packages/disk.scm
@@ -10,6 +10,7 @@
 ;;; Copyright © 2017 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;; Copyright © 2017 Stefan Reichör <stefan@xsteve.at>
 ;;; Copyright © 2018 Vasile Dumitrascu <va511e@yahoo.com>
+;;; Copyright © 2018 Eric Bavier <bavier@member.fsf.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -35,6 +36,7 @@
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages check)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages docbook)
   #:use-module (gnu packages gettext)
@@ -502,3 +504,32 @@ your data as it changes, without having to
re-checksum unchanged data. 
 Duperemove can also take input from the @command{fdupes} program.")
     (license license:gpl2)))
+
+(define-public ranger
+  (package
+    (name "ranger")
+    (version "1.9.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://ranger.github.io/"
+                                  "ranger-" version ".tar.gz"))
+              (sha256
+               (base32
+
"1lnzkrxcnlwnyi3z0v8ybyp8d5rm26qm35rr68kbs2lbs06inha0"))))
+    (build-system python-build-system)
+    (native-inputs                      ;for tests
+     `(("python-pytest" ,python-pytest)
+       ("python-pylint" ,python-pylint)
+       ("python-flake8" ,python-flake8)
+       ("which" ,which)))
+    (arguments
+     '(#:phases (modify-phases %standard-phases
+                  (replace 'check
+                    (lambda _ (invoke "make" "test"))))))
+    (home-page "https://ranger.github.io/")
+    (synopsis "Console file manager")
+    (description "@code{ranger} is a console file manager with VI key
+bindings.  It provides a minimalistic and nice curses interface with a
view on +the directory hierarchy.  It ships with @code{rifle}, a file
launcher that is +good at automatically finding out which program to
use for what file type.")
+    (license license:gpl3)))
-- 
2.17.0

[bug#31252] [PATCH] gnu: Add Ranger.

[Ludovic Courtès]

Eric Bavier <ericbavier@centurylink.net> skribis:

> From 03abb95c7e551ea45d0742bf72cb78e5f0ce210e Mon Sep 17 00:00:00 2001
> From: Eric Bavier <ericbavier@centurylink.net>
> Date: Tue, 24 Apr 2018 18:44:38 -0500
> Subject: [PATCH] gnu: Add Ranger.
> To: guix-patches@gnu.org
>
> From: Eric Bavier <bavier@member.fsf.org>
>
> * gnu/packages/disk.scm (ranger): New variable.

[...]

> +(define-public ranger
> +  (package
> +    (name "ranger")
> +    (version "1.9.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://ranger.github.io/"
> +                                  "ranger-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +
> "1lnzkrxcnlwnyi3z0v8ybyp8d5rm26qm35rr68kbs2lbs06inha0"))))

Patch was mangled.  :-)

> +    (build-system python-build-system)
> +    (native-inputs                      ;for tests
> +     `(("python-pytest" ,python-pytest)
> +       ("python-pylint" ,python-pylint)
> +       ("python-flake8" ,python-flake8)
> +       ("which" ,which)))
> +    (arguments
> +     '(#:phases (modify-phases %standard-phases
> +                  (replace 'check
> +                    (lambda _ (invoke "make" "test"))))))

You can use #:test-target "test" instead.

> +    (home-page "https://ranger.github.io/")
> +    (synopsis "Console file manager")
> +    (description "@code{ranger} is a console file manager with VI key

Nitpick: “Ranger” (or “ranger”?) and “Vi”.

I haven’t tried using it, but otherwise LGTM.  Thanks!

Ludo’.

bug#31252: [PATCH] gnu: Add Ranger.

[Eric Bavier]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

On Wed, 25 Apr 2018 23:09:39 +0200
ludo@gnu.org (Ludovic Courtès) wrote:

> Eric Bavier <ericbavier@centurylink.net> skribis:
> 
> > +    (arguments
> > +     '(#:phases (modify-phases %standard-phases
> > +                  (replace 'check
> > +                    (lambda _ (invoke "make" "test"))))))  
> 
> You can use #:test-target "test" instead.
> 
> > +    (home-page "https://ranger.github.io/")
> > +    (synopsis "Console file manager")
> > +    (description "@code{ranger} is a console file manager with VI key  
> 
> Nitpick: “Ranger” (or “ranger”?) and “Vi”.
> 
> I haven’t tried using it, but otherwise LGTM.  Thanks!

Thanks for the review.

Pushed in 834b0b9a5ca7ebd2cd3c1b2fe8dcb99e5e2f0841 and
adfc742c420f34ecf925ea00d49204f9863bce33 (forgot to apply fixes before pushing ... oops).

`~Eric

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]