From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBIjR-0002DT-8q for guix-patches@gnu.org; Wed, 25 Apr 2018 07:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBIjO-0004vM-63 for guix-patches@gnu.org; Wed, 25 Apr 2018 07:37:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:59131) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fBIjO-0004vD-23 for guix-patches@gnu.org; Wed, 25 Apr 2018 07:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fBIjN-0007yi-SI for guix-patches@gnu.org; Wed, 25 Apr 2018 07:37:01 -0400 Subject: [bug#31259] [PATCH] Add gnuradio Resent-Message-ID: Date: Wed, 25 Apr 2018 13:36:27 +0200 From: Danny Milosavljevic Message-ID: <20180425133627.35995620@scratchpost.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/BnNpnNv+s2L12=z3jQHkY5g"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Charlie Ritter Cc: 31259@debbugs.gnu.org --Sig_/BnNpnNv+s2L12=z3jQHkY5g Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi! Thanks for the patch. I have the following suggestions: * Please unbundle volk. * Please build the documentation (that needs doxygen, ghostscript and texli= ve-tiny). After that, remove docs/doxygen/html/_formulas.log because it co= ntains timestamps. * Please add dependency to alsa-lib. * Please add dependency to libusb. * Why not fftwf? * We should investigate whether grc actually needs the inputs to be propaga= ted (later). * Please add dependency to cppunit. * Please add dependency to orc. * Swig probably is not needed at runtime - isn't a native-input enough? --Sig_/BnNpnNv+s2L12=z3jQHkY5g Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlrgaDsACgkQ5xo1VCww uqVTBwf/Qh7rWoSkyBor/pIqF/wQSsQr3eUe/POHa2Oo92+AURB3hFBhRFTCQ/Cn V5+0pTsQBtdmS7xQtvbdaPo9lbWG4lqDN1LrcdOFRinMKejpEaLOpgndpzXwp2rg 9jRpwIY3SEBy5Q6ymzgD2cCzkr+kW+oTvBo+ASVcdDekNDYKb9ANbrzwG/pzOO28 usgaG/mo8brE39ShR0cRMZpvQnqxsaHrwvbIAZn6TaVPHltrhngfnMZXnACCp4eE QHZD/DduGYcTc4UFLzdMqVZ0x6AP2hyuQ7+D/sNgcg04JZdCyiYla4xX08I4SgEo c/9elmm/xGYYjJnCagtPbXO6B2IDZg== =EIpF -----END PGP SIGNATURE----- --Sig_/BnNpnNv+s2L12=z3jQHkY5g--