From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAbvu-0005Gv-Nv for guix-patches@gnu.org; Mon, 23 Apr 2018 09:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAbvq-0005SW-6i for guix-patches@gnu.org; Mon, 23 Apr 2018 09:55:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56978) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAbvq-0005S9-3W for guix-patches@gnu.org; Mon, 23 Apr 2018 09:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fAbvp-0005sJ-Sx for guix-patches@gnu.org; Mon, 23 Apr 2018 09:55:01 -0400 Subject: bug#31244: [PATCH] ffmpeg 4.0 update patch series Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Mon, 23 Apr 2018 15:54:01 +0200 From: Rutger Helling Message-ID: <20180423155401.0e5ef117@mykolab.com> In-Reply-To: <87muxu135k.fsf@gnu.org> References: <20180423092812.1ddba41d@mykolab.com> <87muxu135k.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/Z4b+jhAQmC.6n8FjTsEIB.P"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31244-done@debbugs.gnu.org --Sig_/Z4b+jhAQmC.6n8FjTsEIB.P Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for the review and explanation! I've squashed the commits and pushed. On Mon, 23 Apr 2018 15:08:23 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Hello Rutger, >=20 > Rutger Helling skribis: >=20 > > this patch series updates ffmpeg to 4.0. Since I found that a few > > packages fail to build with ffmpeg 4.0 I've also added ffmpeg@3.4 > > for compatibility. > > > > Furthermore I've removed ffmpeg-git and changed mpv to build with > > ffmpeg 4.0 instead. =20 >=20 > This all looks good to me, but I have one request: could you squash > all the changes, except perhaps the one removing =E2=80=98ffmpeg-git=E2= =80=99? >=20 > The rationale is that each commit should leave the repo in a =E2=80=9Cgoo= d=E2=80=9D > state, which would not be the case if we first install the patch that > upgrades ffmpeg and only then apply the ffmpeg =E2=86=92 ffmpeg-3.4 chang= es. >=20 > I hope that=E2=80=99s fine with you. >=20 > Thanks for working on it! >=20 > Ludo=E2=80=99. --Sig_/Z4b+jhAQmC.6n8FjTsEIB.P Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEAVThuRzJ2e93ZI3n86cn20T8yjYFAlrd5XkACgkQ86cn20T8 yjZ0Rwf/eJwQ6r1WYhVRCyygSWNCZ79+ERN5bIvvpWnvzrlhmPjrTuIDzNlvkDUL kwk/UYVGgxWnFcVZ3QBUdxWGKisb9OGCWq0wxPaOLPFK/r++k/pILM2lohBoNwRZ +HeUJ07ah6PEuXo5yOeHpgIxlWWrd1l7V6LRte+xeuJfTA6CD4B3+T6lXs4p5D8e HZ2Ly53UYSwWsq3Jt8B74lKIEyUYlueEcf3ARk1mAunt6BcxhTLSlOMpKZwa/6Y1 o1YpXB4oWxkI6e/rzMSTQOPPMZHklRnV/yPcKTt7pbl+hVRSSen0NIA2apQv9+2P IMRYtf5ge+TFP2y0/pvv0gATmi7zMg== =m8FM -----END PGP SIGNATURE----- --Sig_/Z4b+jhAQmC.6n8FjTsEIB.P--