Thanks for the review and explanation! I've squashed the commits and pushed. On Mon, 23 Apr 2018 15:08:23 +0200 ludo@gnu.org (Ludovic Courtès) wrote: > Hello Rutger, > > Rutger Helling skribis: > > > this patch series updates ffmpeg to 4.0. Since I found that a few > > packages fail to build with ffmpeg 4.0 I've also added ffmpeg@3.4 > > for compatibility. > > > > Furthermore I've removed ffmpeg-git and changed mpv to build with > > ffmpeg 4.0 instead. > > This all looks good to me, but I have one request: could you squash > all the changes, except perhaps the one removing ‘ffmpeg-git’? > > The rationale is that each commit should leave the repo in a “good” > state, which would not be the case if we first install the patch that > upgrades ffmpeg and only then apply the ffmpeg → ffmpeg-3.4 changes. > > I hope that’s fine with you. > > Thanks for working on it! > > Ludo’.