From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9m8t-0001RR-QY for guix-patches@gnu.org; Sat, 21 Apr 2018 02:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9m8s-0000pw-Ri for guix-patches@gnu.org; Sat, 21 Apr 2018 02:37:03 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:54878) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9m8s-0000pl-Nv for guix-patches@gnu.org; Sat, 21 Apr 2018 02:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f9m8s-0003Vy-Hx for guix-patches@gnu.org; Sat, 21 Apr 2018 02:37:02 -0400 Subject: bug#31173: [PATCH] gnu: Add python-onetimepass. Resent-To: guix-patches@gnu.org Resent-Message-ID: Date: Sat, 21 Apr 2018 08:36:20 +0200 From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Message-ID: <20180421063620.GA1534@doom> References: <20180416090552.14421-1-sleep_walker@gnu.org> <87tvsabwf4.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pWyiEgJYm5f9v55/" Content-Disposition: inline In-Reply-To: <87tvsabwf4.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 31173-done@debbugs.gnu.org --pWyiEgJYm5f9v55/ Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 17, 2018 at 12:47:59AM +0200, Marius Bakke wrote: >Tom=C3=A1=C5=A1 =C4=8Cech writes: > >> * gnu/packages/python.scm (python-onetimepass): New variable. > >[...] > >> +(define-public python-onetimepass >> + (package >> + (name "python-onetimepass") > >Please check the indentation of this package. Use >'./etc/indent-code.el' if you're not an emacs user. as with other patches I sent - I run it through and result is unchanged. But I'll be careful about that, thanks! >> + (version "1.0.1") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (pypi-uri "onetimepass" version)) >> + (sha256 >> + (base32 >> + "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5")))) >> + (build-system python-build-system) >> + (inputs >> + `(("python-six" ,python-six))) > >Should this not be a propagated input? It didn't seem so. >> + (home-page "https://github.com/tadeck/onetimepass/") >> + (synopsis "Python one-time password library") > >Maybe s/Python// even. Fixed. >> + (description "Pyhton one-time password library for HMAC-based (HOTP= ) and > ^^^ typo (importo?) Fixed. >> +time-based (TOTP) passwords.") > >Please also turn this into a complete sentence. "@code{onetimepass} is >a Python library for...". Bonus points if you can mention use-cases and >in general expand on it :-) > >> + (license license:x11))) > >I believe this is "expat". Fixed. >Otherwise LGTM. Pushed. Thank you for your review! Best regards, S_W --pWyiEgJYm5f9v55/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEDOrssfr9jDQthC2PSiPjT6AzQ20FAlra2+QACgkQSiPjT6Az Q22CpRAAg3StVO13wxSWMZ5JRpFN8hVCSeEx5FtMeUbYp/U4mZ1Sj0/npH5IYFBh 6+PxMwzIpZi2pCvsZPv73WklLjB8/qypc6WGtw8yG5tZiScIkelqVO4RQT3WRlyW d3u7GBxzdQhUooJf91KLdl6Mr6EwbEM68TP9Z+m+E0t098nZc9jWgfAqHei6AytA MPrpfNDJtexcpOUa1yK0BTibRixS03teUyd8PlXoUGJjPflxWiskOReqJnH8fyXT Cnj6g/3t1AUHQssdMxgt9haZjer/MAcAwpAozviGG5QNoGQLBABE86Fq31TTEB2z FQZteSiX7npAyDKRWv7epSBoRXyc3BKm6gZgc4w7+lOEFpeyQQZVw3Wa79/dAGfh 5KM6YhFKAURYXNBqDjdWFSTfB+dNhwCDbNjg6CVi5ipm/1LHB0SO5JYqok9Yx4QF 6CYLorNg75bEPghocduKmk8ixyCWkNSbZFxnM0wPN7D8foaOONjMHy3WPRVq95io 6+gCx5lrykeDR8/Jy5VbtuOyDgWgqsnG3buHp+/5GdfF1yXNndj3b2jIsCjV3Mo9 cRg5ffhwgLNE5eQUCcMqsb9mbpocrsjcYms1xgZ+lNY7waShcEW/jShdRNt0qRGo m0Db7mJn1trQvx55C2rIDIEF/fgg6NHYRghxRVt/9KAE/a8nesY= =fACD -----END PGP SIGNATURE----- --pWyiEgJYm5f9v55/--