From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8mJj-0003vN-88 for guix-patches@gnu.org; Wed, 18 Apr 2018 08:36:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8mJf-00060j-5q for guix-patches@gnu.org; Wed, 18 Apr 2018 08:36:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:50675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8mJf-00060d-1P for guix-patches@gnu.org; Wed, 18 Apr 2018 08:36:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8mJe-0002of-R4 for guix-patches@gnu.org; Wed, 18 Apr 2018 08:36:02 -0400 Subject: [bug#31121] [PATCH 3/3] gnu: Add osc. Resent-Message-ID: Date: Wed, 18 Apr 2018 14:34:46 +0200 From: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= Message-ID: <20180418123446.GA17933@doom> References: <87sh7udd03.fsf@fastmail.com> <20180417214042.31132-1-sleep_walker@gnu.org> <878t9kbw0x.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Content-Disposition: inline In-Reply-To: <878t9kbw0x.fsf@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 31121@debbugs.gnu.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Wed, Apr 18, 2018 at 01:21:02PM +0200, Marius Bakke wrote: >Tom=C3=A1=C5=A1 =C4=8Cech writes: > >> * gnu/packages/build-tools.scm (osc): New variable. > >[...] > >> +(define-public osc >> + (package >> + (name "osc") > ^ >Indentation off here too. I'm sorry, I'm a bit confused here. My Emacs indent the code like this and indent script you pointed in previous mail doesn't change it for me. You would like me to reduce one space? Like this? (define-public osc (package (name "osc") It seems that this is not unified in the code. Can I somehow teach my Emacs indentantation rules? Thanks for your patienece. > >> + (version "0.162.1") >> + (source >> + (origin >> + (method url-fetch) > ^ >And here. > >> + (uri (string-append "https://github.com/openSUSE/" name >> + "/archive/" version ".tar.gz")) >> + (file-name (string-append name "-" version ".tar.gz")) >> + (sha256 >> + (base32 "0b4kpm96ns4smqyfjysbk2p78d36x44xprpna8zz85q1y5xn57aj")= ))) >> + (build-system python-build-system) >> + (arguments >> + `(#:python ,python-2 ;; Module is python2 only. > ^ >Only one semicolon for margin comments. Ack. > >> + #:phases >> + (modify-phases %standard-phases >> + (add-after 'install 'fix-filename-and-remove-unused >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((bin (string-append (assoc-ref outputs "out") "/bin/= "))) >> + ;; Main osc tool is renamed in spec file, not setup.py, = let's >> + ;; do that too. >> + (rename-file >> + (string-append bin "osc-wrapper.py") >> + (string-append bin "osc")) >> + ;; Remove unused and broken script. >> + (delete-file (string-append bin "osc_hotshot.py")) >> + #t)))))) >> + (inputs >> + `(("python2-m2crypto" ,python2-m2crypto) >> + ("python2-pycurl" ,python2-pycurl) >> + ("python2-urlgrabber" ,python2-urlgrabber))) >> + (home-page "https://github.com/openSUSE/osc") >> + (synopsis "Open Build Service command line tool") >> + (description "@command{osc} is command line interface to Open Build > ^^^ ^^^ > "is a" "to the" >Other than that LGTM. \o/ Best regards, S_W --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEDOrssfr9jDQthC2PSiPjT6AzQ20FAlrXO2YACgkQSiPjT6Az Q21+EA/8DK4hqO7Hiqj0Ja4Jv3Ay0gGFlP5Jc+kS/wLZiP+wXVGpGFmoW0aabDCw 5yUfrHkniNlAqOuNoP+ebZoRe/8RGZVt4c0RIgaVTKeW8hYDxIgdepBip3Q7DStV Ygn3lmgT4RUAX9LaPml+QpgUbQuO3wEkAnhsMeTh8NL4LGVYpn0Pu4luRA1A84b1 zU8HlFc5G8BSnCOFZ3LWVd1dq4EpxE1ziqSpa4Q9Lw7FwnoRV99kCbSZDoGIgo/q Zj+XEVSJBgEQD/GTtFWq/TlaSEOF+QVkldWeyLjSc8Bc8bUhuVS+DChQW5hh30+8 Uga/hZojo+tY8HWDrtDF5VXiu+Mne1UBYZu+1rtHlf+Pvw4vxdhlOZTpsLw4SXVz I4avdJaOGTdpt9hl1VhPaRtnIu9xQ0I2IO5/Shw+Fow/tvOyRYrVnZ2aSrgedjgt 8ObEuvss324LWQBvjNuWa6WOW+ygT+Hnx9Lz/ogc887qJe0x8NN2e5bFTlzbiCoP ZM4zhN7fBY/fV+W4epM8Hpxl4p6x+H9y+N0Bo7fi4sKX5FUhsxBdt5i4EELlak8k TuNGE/88cd9wVGjj/0zc6ewLupziSefgni3ODnSn/sIXE0+LPl13HUAzz2Ukr47j AIc1C/6S6TF2gLDBQN+MHGtIzv/iI9aNTy+OSk2OjeHzS1tiWRk= =ItJV -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--