unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
@ 2018-04-15  8:49 Tomáš Čech
  2018-04-16 22:24 ` Marius Bakke
  2018-08-29 21:30 ` bug#31160: " Leo Famulari
  0 siblings, 2 replies; 5+ messages in thread
From: Tomáš Čech @ 2018-04-15  8:49 UTC (permalink / raw)
  To: 31160

* gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
via configure flag.
---
 gnu/packages/linux.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index c09e0474a..c80cadb6c 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -2121,6 +2121,7 @@ time.")
                                               "/etc/lvm")
                                "--enable-udev_sync"
                                "--enable-udev_rules"
+                               "--enable-pkgconfig"
 
                                ;; Make sure programs such as 'dmsetup' can
                                ;; find libdevmapper.so.
-- 
2.16.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
  2018-04-15  8:49 [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation Tomáš Čech
@ 2018-04-16 22:24 ` Marius Bakke
  2018-04-17  7:07   ` Tomáš Čech
  2018-08-29 21:30 ` bug#31160: " Leo Famulari
  1 sibling, 1 reply; 5+ messages in thread
From: Marius Bakke @ 2018-04-16 22:24 UTC (permalink / raw)
  To: Tomáš Čech, 31160

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

Tomáš Čech <sleep_walker@gnu.org> writes:

> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
> via configure flag.

LGTM, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
  2018-04-16 22:24 ` Marius Bakke
@ 2018-04-17  7:07   ` Tomáš Čech
  2018-04-17 20:52     ` Marius Bakke
  0 siblings, 1 reply; 5+ messages in thread
From: Tomáš Čech @ 2018-04-17  7:07 UTC (permalink / raw)
  To: Marius Bakke; +Cc: 31160

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

On Tue, Apr 17, 2018 at 12:24:07AM +0200, Marius Bakke wrote:
>Tomáš Čech <sleep_walker@gnu.org> writes:
>
>> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
>> via configure flag.
>
>LGTM, thanks!

Is it OK for me to push it into master directly? I'm not sure how big
is dependency subtree for such lowlevel package... Is there easy way,
how to print dependency subtree?

Thanks in advance.

Best regards,

S_W

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation.
  2018-04-17  7:07   ` Tomáš Čech
@ 2018-04-17 20:52     ` Marius Bakke
  0 siblings, 0 replies; 5+ messages in thread
From: Marius Bakke @ 2018-04-17 20:52 UTC (permalink / raw)
  To: Tomáš Čech; +Cc: 31160

[-- Attachment #1: Type: text/plain, Size: 833 bytes --]

Tomáš Čech <sleep_walker@gnu.org> writes:

> On Tue, Apr 17, 2018 at 12:24:07AM +0200, Marius Bakke wrote:
>>Tomáš Čech <sleep_walker@gnu.org> writes:
>>
>>> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
>>> via configure flag.
>>
>>LGTM, thanks!
>
> Is it OK for me to push it into master directly? I'm not sure how big
> is dependency subtree for such lowlevel package... Is there easy way,
> how to print dependency subtree?

There is!  `guix refresh -l lvm2{,-static}` will tell you exactly how
many packages are affected.  On current 'master', only 37 packages will
be rebuilt.

So it should be fine for the master branch.  It's good if you try to
build some of the dependent packages before pushing however, to make
sure it does not cause any regressions.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#31160: [PATCH] gnu: lvm2: Enable pkg-config files generation.
  2018-04-15  8:49 [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation Tomáš Čech
  2018-04-16 22:24 ` Marius Bakke
@ 2018-08-29 21:30 ` Leo Famulari
  1 sibling, 0 replies; 5+ messages in thread
From: Leo Famulari @ 2018-08-29 21:30 UTC (permalink / raw)
  To: Tomáš Čech; +Cc: 31160-done

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

On Sun, Apr 15, 2018 at 10:49:28AM +0200, Tomáš Čech wrote:
> * gnu/packages/linux.scm (lvm2)[arguments]: Enable pkg-config files generation
> via configure flag.

Pushed as 9324d92e6a3ef030193f43d21a75ca3e88fa90b4

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-08-29 21:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-15  8:49 [bug#31160] [PATCH] gnu: lvm2: Enable pkg-config files generation Tomáš Čech
2018-04-16 22:24 ` Marius Bakke
2018-04-17  7:07   ` Tomáš Čech
2018-04-17 20:52     ` Marius Bakke
2018-08-29 21:30 ` bug#31160: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).