On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Courtès wrote:
>Hello,
>
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>>  * gnu/packages/linux.scm (libcgroup): New variable.
>
>[...]
>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         ;; tests try to mount cgroup filesystem and fails because it seems it
>> +         ;; can't be mounted twice
>> +         ;; let's disable it
>> +         (delete 'check))))
>
>Simply write #:tests? #f.
>
>> +    (native-inputs
>> +     `(("bison" ,bison)
>> +       ("flex" ,flex)
>> +       ("linux-pam" ,linux-pam)))
>
>Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?
>
>Otherwise LGTM, thanks!

Both things addressed, result pushed.

Thanks for review!

S_W