From: "Tomáš Čech" <sleep_walker@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 31087-done@debbugs.gnu.org
Subject: bug#31087: [PATCH] gnu: Add libcgroup.
Date: Tue, 10 Apr 2018 12:05:59 +0200 [thread overview]
Message-ID: <20180410100559.GD23836@doom> (raw)
In-Reply-To: <87o9isglsu.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Courtès wrote:
>Hello,
>
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>> * gnu/packages/linux.scm (libcgroup): New variable.
>
>[...]
>
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + ;; tests try to mount cgroup filesystem and fails because it seems it
>> + ;; can't be mounted twice
>> + ;; let's disable it
>> + (delete 'check))))
>
>Simply write #:tests? #f.
>
>> + (native-inputs
>> + `(("bison" ,bison)
>> + ("flex" ,flex)
>> + ("linux-pam" ,linux-pam)))
>
>Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?
>
>Otherwise LGTM, thanks!
Both things addressed, result pushed.
Thanks for review!
S_W
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-10 10:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 11:21 [bug#31087] [PATCH] gnu: Add libcgroup Tomáš Čech
2018-04-07 15:17 ` Tomáš Čech
2018-04-09 20:35 ` Ludovic Courtès
2018-04-10 10:05 ` Tomáš Čech [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410100559.GD23836@doom \
--to=sleep_walker@gnu.org \
--cc=31087-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).