[bug#31087] [PATCH] gnu: Add libcgroup.

[bug#31087] [PATCH] gnu: Add libcgroup.

[Tomáš Čech]

 * gnu/packages/linux.scm (libcgroup): New variable.
---
 gnu/packages/linux.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index b6333af99..18956bd0f 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4562,3 +4562,32 @@ text-mode or graphical applications that don't use a display server.
 Also included is @command{fbgrab}, a wrapper around @command{fbcat} that
 emulates the behaviour of Gunnar Monell's older fbgrab utility.")
     (license license:gpl2)))
+
+(define-public libcgroup
+  (package
+    (name "libcgroup")
+    (version "0.41")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://sourceforge/libcg/" name "/"
+             version "/" name "-" version ".tar.bz2"))
+       (sha256
+        (base32 "0lgvyq37gq84sk30sg18admxaj0j0p5dq3bl6g74a1ppgvf8pqz4"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests try to mount cgroup filesystem and fails because it seems it
+         ;; can't be mounted twice
+         ;; let's disable it
+         (delete 'check))))
+    (native-inputs
+     `(("bison" ,bison)
+       ("flex" ,flex)
+       ("linux-pam" ,linux-pam)))
+    (home-page "https://sourceforge.net/projects/libcg/")
+    (synopsis "Userspace interface to control groups features in Linux kernel")
+    (description "TBD")
+    (license license:lgpl2.1)))
-- 
2.16.3

[bug#31087] [PATCH] gnu: Add libcgroup.

[Tomáš Čech]

 * gnu/packages/linux.scm (libcgroup): New variable.
---
 gnu/packages/linux.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index b6333af99..582862865 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -4562,3 +4562,34 @@ text-mode or graphical applications that don't use a display server.
 Also included is @command{fbgrab}, a wrapper around @command{fbcat} that
 emulates the behaviour of Gunnar Monell's older fbgrab utility.")
     (license license:gpl2)))
+
+(define-public libcgroup
+  (package
+    (name "libcgroup")
+    (version "0.41")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://sourceforge/libcg/" name "/"
+             version "/" name "-" version ".tar.bz2"))
+       (sha256
+        (base32 "0lgvyq37gq84sk30sg18admxaj0j0p5dq3bl6g74a1ppgvf8pqz4"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; tests try to mount cgroup filesystem and fails because it seems it
+         ;; can't be mounted twice
+         ;; let's disable it
+         (delete 'check))))
+    (native-inputs
+     `(("bison" ,bison)
+       ("flex" ,flex)
+       ("linux-pam" ,linux-pam)))
+    (home-page "https://sourceforge.net/projects/libcg/")
+    (synopsis "Control groups management tools")
+    (description "Control groups is Linux kernel method for process resource
+restriction, permission handling and more.  This package provides userspace
+interface to this kernel feature.")
+    (license license:lgpl2.1)))
-- 
2.17.0

[bug#31087] [PATCH] gnu: Add libcgroup.

[Ludovic Courtès]

Hello,

Tomáš Čech <sleep_walker@gnu.org> skribis:

>  * gnu/packages/linux.scm (libcgroup): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         ;; tests try to mount cgroup filesystem and fails because it seems it
> +         ;; can't be mounted twice
> +         ;; let's disable it
> +         (delete 'check))))

Simply write #:tests? #f.

> +    (native-inputs
> +     `(("bison" ,bison)
> +       ("flex" ,flex)
> +       ("linux-pam" ,linux-pam)))

Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?

Otherwise LGTM, thanks!

Ludo’.

bug#31087: [PATCH] gnu: Add libcgroup.

[Tomáš Čech]

[-- Attachment #1: Type: text/plain, Size: 809 bytes --]

On Mon, Apr 09, 2018 at 10:35:45PM +0200, Ludovic Courtès wrote:
>Hello,
>
>Tomáš Čech <sleep_walker@gnu.org> skribis:
>
>>  * gnu/packages/linux.scm (libcgroup): New variable.
>
>[...]
>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         ;; tests try to mount cgroup filesystem and fails because it seems it
>> +         ;; can't be mounted twice
>> +         ;; let's disable it
>> +         (delete 'check))))
>
>Simply write #:tests? #f.
>
>> +    (native-inputs
>> +     `(("bison" ,bison)
>> +       ("flex" ,flex)
>> +       ("linux-pam" ,linux-pam)))
>
>Should ‘linux-pam’ be in ‘inputs’ rather than ‘native-inputs’?
>
>Otherwise LGTM, thanks!

Both things addressed, result pushed.

Thanks for review!

S_W

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]