From: Eric Bavier <ericbavier@centurylink.net>
To: Adam Massmann <massmannak@gmail.com>
Cc: 31007-done@debbugs.gnu.org
Subject: bug#31007: [PATCH] gnu: Add xapers.
Date: Wed, 4 Apr 2018 09:39:15 -0500 [thread overview]
Message-ID: <20180404093915.509bae99@centurylink.net> (raw)
In-Reply-To: <87efjvqxph.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]
On Wed, 04 Apr 2018 02:42:34 -0400
Adam Massmann <massmannak@gmail.com> wrote:
> Hi Eric,
>
> Thank you very much for reviewing the patch and providing the
> feedback. I was able to make the fixes you pointed out and attached the
> updated patches below. I also fixed some mistakes on alphabetical order
> I had missed.
Great, thank you!
>
> While digging more into the missing tests for pybtex I realized that the
> problems with tests were actually an error on my part - I apologize! I
> misinterpreted some output as suggesting that tests were missing, when
> in reality I was letting Guix send the wrong test target to
> python-build. This is fixed now and the tests work.
Awesome.
>
> Thanks again for your time spent on the contribution; it's a big help
> particularly for someone new to this like me.
>
No problem; just paying it forward.
I've pushed these three patches in
c2b2f0c86691f6d76f528b6366c866b8f3665c3c
2514fc1d69ec556c9c18d2463a892f43fa175557
f50bad80a93eabab598f3d6d621818b67cefb70b
with minor changes. Thank you for the contribution; hope to see some
more from you! :)
`~Eric
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-04-04 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 18:00 [bug#31007] [PATCH] gnu: Add xapers Adam Massmann
2018-04-02 22:37 ` Eric Bavier
2018-04-04 6:42 ` Adam Massmann
2018-04-04 14:39 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180404093915.509bae99@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=31007-done@debbugs.gnu.org \
--cc=massmannak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).