From: Eric Bavier <ericbavier@centurylink.net>
To: Adam Massmann <massmannak@gmail.com>
Cc: 31007@debbugs.gnu.org
Subject: [bug#31007] [PATCH] gnu: Add xapers.
Date: Mon, 2 Apr 2018 17:37:32 -0500 [thread overview]
Message-ID: <20180402173732.520974f3@centurylink.net> (raw)
In-Reply-To: <87bmf42khy.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 5037 bytes --]
Hello Adam,
On Sat, 31 Mar 2018 14:00:25 -0400
Adam Massmann <massmannak@gmail.com> wrote:
> Hi,
>
> This is a patch to add xapers (https://finestructure.net/xapers/) and
> dependencies. I followed the steps in Contributing: Submitting Patches,
> but this is my first time contributing so I apologize if I made any
> mistakes.
Welcome! Thank you for your contribution.
> Thanks a lot for the work on Guix, I've really enjoyed using it.
Glad you've enjoyed it.
Just a few suggestions:
First, could you add a copyright line for yourself on each of the
affected files?
> ---
> gnu/packages/python.scm | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 9e038ef4f..f505f15b2 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13082,3 +13082,22 @@ file system events on Linux.")
> (base32
> "0svc9nla3b9145d6b7fb9dizx412l3difzqw0ilh9lz52nsixw8j"))
> (file-name (string-append name "-" version ".tar.gz"))))))
> +
> +(define-public python-latexcodec
> + (package
> + (name "python-latexcodec")
[...]
> + (synopsis "Lexer and codec to work with LaTeX code in Python")
Maybe leave out the "Lexer and codec to" bit so this becomes "Work with
LaTeX code in Python" to make the synopsis more approachable.
>
>
> From f506eb11811eef1461b382d6d3cbcc273e62ad3d Mon Sep 17 00:00:00 2001
> From: Adam Massmann <massmannak@gmail.com>
> Date: Sat, 31 Mar 2018 13:08:11 -0400
> Subject: [PATCH 2/3] gnu: Add python-pybtex.
>
> ---
> gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index f505f15b2..056a05235 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -13101,3 +13101,35 @@ file system events on Linux.")
> (synopsis "Lexer and codec to work with LaTeX code in Python")
> (description "Lexer and codec to work with LaTeX code in Python.")
> (license license:expat)))
> +
> +(define-public python-pybtex
> + (package
> + (name "python-pybtex")
> + (version "0.21")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "pybtex" version))
> + (sha256
> + (base32
> + "00300j8dn5pxq4ndxmfmbmycg2znawkqs49val2x6jlmfiy6r2mg"))))
> + (build-system python-build-system)
> + (native-inputs
> + `(("python-nose" ,python-nose)))
> + (inputs
> + `(("python-latexcodec" ,python-latexcodec)
> + ("python-pyyaml" ,python-pyyaml)
> + ("python-six" ,python-six)))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (replace 'check
> + ;; hack, where did the tests go?
> + (lambda _
> + (zero? 0))))))
Could you use "#:tests? #f" instead, and expand on exactly why the
tests are not being run (seems there are none?).
> +(define-public xapers
> + (package
> + (name "xapers")
> + (version "0.8.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://finestructure.net/xapers/releases/xapers-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "0ykz6hn3qj46w3c99d6q0pi5ncq2894simcl7vapv047zm3cylmd"))))
> + (build-system python-build-system)
> + (propagated-inputs
> + `(("python-urwid" ,python-urwid)))
> + (inputs
> + `(("poppler" ,poppler)
> + ("python" ,python)
> + ("python-xapian-bindings" ,python-xapian-bindings)
> + ("python-pycurl" ,python-pycurl)
> + ("python-latexcodec" ,python-latexcodec)
> + ("python-pybtex" ,python-pybtex)
> + ("python-pyyaml" ,python-pyyaml)
> + ("python-six" ,python-six)))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after
> + 'install 'install-doc
Put these on the same line as "add-after".
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (bin (string-append out "/bin"))
> + (man1 (string-append out "/share/man/man1")))
> + (mkdir-p bin)
> + (mkdir-p man1)
> + (copy-file "man/man1/xapers.1"
> + (string-append man1 "/xapers.1"))
> + (copy-file "man/man1/xapers-adder.1"
> + (string-append man1 "/xapers-adder.1"))
> + (copy-file "bin/xapers-adder"
> + (string-append bin "/xapers-adder"))))))))
^
Use "install-file" here. It also creates the target directory, so you
can remove the mkdir-p's above.
Otherwise looks good to me. Could you send an updated patch?
Thanks,
`~Eric
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-04-02 22:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-31 18:00 [bug#31007] [PATCH] gnu: Add xapers Adam Massmann
2018-04-02 22:37 ` Eric Bavier [this message]
2018-04-04 6:42 ` Adam Massmann
2018-04-04 14:39 ` bug#31007: " Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180402173732.520974f3@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=31007@debbugs.gnu.org \
--cc=massmannak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).