From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1evUc2-0004B4-Kn for guix-patches@gnu.org; Mon, 12 Mar 2018 17:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1evUby-0000J4-H8 for guix-patches@gnu.org; Mon, 12 Mar 2018 17:04:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:49662) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1evUby-0000J0-DN for guix-patches@gnu.org; Mon, 12 Mar 2018 17:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1evUby-0003Uw-32 for guix-patches@gnu.org; Mon, 12 Mar 2018 17:04:02 -0400 Subject: [bug#30748] [PATCH] gnu: Add nsd. Resent-Message-ID: Date: Mon, 12 Mar 2018 22:03:16 +0100 From: Danny Milosavljevic Message-ID: <20180312220316.7ae887eb@scratchpost.org> In-Reply-To: <87lgf0jnlj.fsf@fastmail.com> References: <20180308082050.9855-1-me@tobias.gr> <87lgf0jnlj.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/SwHzJZc+F8qFiqdKmHOxfu6"; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke , Tobias Geerinckx-Rice Cc: 30748@debbugs.gnu.org --Sig_/SwHzJZc+F8qFiqdKmHOxfu6 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Marius, Hi Tobias, > > + (add-before 'configure 'patch-installation-paths > > + (lambda* (#:key outputs #:allow-other-keys) > > + (let* ((out (assoc-ref outputs "out")) > > + (doc (string-append out "/share/doc/" ,name "-" ,v= ersion))) > > + (substitute* "Makefile.in" > > + (((string-append ".*\\$\\(DESTDIR\\)\\$\\(" > > + "(config|pid|xfr|db)dir" > > + "\\).*")) > > + "") =20 >=20 > Can you add a comment about what's going on here? I agree... I'm scratching my head here. The ".*" is particularily worrying. Doesn't that mean it will replace all the installation lines by nothing in = the end? Does that install anything still? :) So now I've downloaded the source tarball and checked. By extreme obscurity :), this only matches the "install -d" lines which are creating empty directories (empty because of the configure-flags). > Would setting > DESTDIR=3D(assoc-ref %outputs "out") in #:make-flags suffice? DESTDIR is for installing into a tempdir. After that is done the system is supposed to "mv $tempdir /" and the software is usually written *not* to expect DESTDIR to be still here when it runs. PREFIX is something else and probably what you had in mind. --Sig_/SwHzJZc+F8qFiqdKmHOxfu6 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAlqm6xQACgkQ5xo1VCww uqVt/wf+PxbidI5zYbXayN5pjEaBU9srXIsbY0enAo2O1Hc2djBPcOrhyAmLHql+ Nwy7ilQb2M66o5oNb6KPSMK8KQo8ixzbutDNsEIxSPH960GRW1Bn0f1uFva1+KVS UMkr5aUXsV069dMjVZ1Si2WRbj2Rw8VG75NUBm9+v+4zV7uw7j3UeoS8DtfJ9fbB 9cwHcGA6VvkmxnkI5rFmVkBqyDSUHNnADWDj1ONfovwU4ddKb7d+BQ7tlYa4XZKq opQMB/mO3WcObQ2ZtwGRBEl73OHj7rAc8Vy69AXQHX0xYVZVXaYRHEsTuVncUWq6 /I/k2Y2mPrkFmz/1tp1xnkHPtjfvrQ== =Oqw5 -----END PGP SIGNATURE----- --Sig_/SwHzJZc+F8qFiqdKmHOxfu6--