From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erT7d-0006nA-GD for guix-patches@gnu.org; Thu, 01 Mar 2018 13:40:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erT7a-0005Ot-Px for guix-patches@gnu.org; Thu, 01 Mar 2018 13:40:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:59959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erT7a-0005OD-MF for guix-patches@gnu.org; Thu, 01 Mar 2018 13:40:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1erT7a-0002Yz-A9 for guix-patches@gnu.org; Thu, 01 Mar 2018 13:40:02 -0500 Subject: [bug#30629] [PATCH 4/5] system: Add 'initrd-modules' field. Resent-Message-ID: Date: Thu, 1 Mar 2018 19:39:18 +0100 From: Danny Milosavljevic Message-ID: <20180301193918.35c6e92c@scratchpost.org> In-Reply-To: <20180227142245.12674-5-ludo@gnu.org> References: <20180227142245.12674-1-ludo@gnu.org> <20180227142245.12674-5-ludo@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 30629@debbugs.gnu.org > --- a/gnu/system.scm > +++ b/gnu/system.scm > @@ -74,6 +74,7 @@ > operating-system-kernel > operating-system-kernel-file > operating-system-kernel-arguments > + operating-system-initrd-modules > operating-system-initrd > operating-system-users > operating-system-groups > @@ -152,8 +153,13 @@ booted from ROOT-DEVICE" > (default '())) ; list of gexps/strings > (bootloader operating-system-bootloader) ; > > + Nitpick: Another empty line ? :) Otherwise LGTM!