From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1er97y-0008Cf-3u for guix-patches@gnu.org; Wed, 28 Feb 2018 16:19:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1er97u-00084U-6L for guix-patches@gnu.org; Wed, 28 Feb 2018 16:19:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1er97u-000844-17 for guix-patches@gnu.org; Wed, 28 Feb 2018 16:19:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1er97t-0006dl-QW for guix-patches@gnu.org; Wed, 28 Feb 2018 16:19:01 -0500 Subject: [bug#30654] giflib / khtml build failures Resent-Message-ID: Date: Wed, 28 Feb 2018 23:18:19 +0100 From: Danny Milosavljevic Message-ID: <20180228231819.4b4f5a43@scratchpost.org> In-Reply-To: References: <20180228201202.1481-1-h.goebel@crazy-compilers.com> <0a80adad-2621-d2e6-3df9-5bab94471727@crazy-compilers.com> <20180228225742.77c7707e@scratchpost.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Hartmut Goebel Cc: 30654@debbugs.gnu.org On Wed, 28 Feb 2018 22:06:06 +0100 Hartmut Goebel wrote: > What about renaming the one in giflib into __giflib__reallocmemory? It's > only used 9 times in the whole code. Sure, even better! But I think leading underscore is reserved in C (for exposed compiler-internal functions like crt startup).