From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eq5qs-00052I-00 for guix-patches@gnu.org; Sun, 25 Feb 2018 18:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eq5qo-0003q1-Rl for guix-patches@gnu.org; Sun, 25 Feb 2018 18:37:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:52832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eq5qo-0003ph-NH for guix-patches@gnu.org; Sun, 25 Feb 2018 18:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eq5qo-0006xW-BI for guix-patches@gnu.org; Sun, 25 Feb 2018 18:37:02 -0500 Subject: [bug#30572] [PATCH 5/7] docker: Allow the addition of extra files into the image. Resent-Message-ID: Date: Mon, 26 Feb 2018 00:36:47 +0100 From: Danny Milosavljevic Message-ID: <20180226003647.6174ad02@scratchpost.org> In-Reply-To: <20180222103528.5108-5-cmmarusich@gmail.com> References: <20180222103528.5108-1-cmmarusich@gmail.com> <20180222103528.5108-5-cmmarusich@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Chris Marusich Cc: 30572@debbugs.gnu.org > + (zero? (apply system* "tar" "-C" extra-items-dir > + "-rf" "layer.tar" > + (append %tar-determinism-options > + '(".")))))))) -C is order-sensitive. Apparently it still doesn't cause layer.tar to be created inside extra-items-dir (huh...), but for clarity, I'd prefer: tar -rf layer.tar -C extra-items-dir . Otherwise LGTM!