unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Marius Bakke <mbakke@fastmail.com>
To: 30601@debbugs.gnu.org
Subject: [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf.
Date: Sun, 25 Feb 2018 04:54:38 +0100	[thread overview]
Message-ID: <20180225035438.24171-1-mbakke@fastmail.com> (raw)

* gnu/packages/ninja.scm (ninja)[arguments]: Set #:tests? #f on armhf.  Adjust
CHECK-PHASE accordingly.
---
 gnu/packages/ninja.scm | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/ninja.scm b/gnu/packages/ninja.scm
index adb236484..cff2ac38b 100644
--- a/gnu/packages/ninja.scm
+++ b/gnu/packages/ninja.scm
@@ -42,7 +42,15 @@
     (build-system gnu-build-system)
     (native-inputs `(("python" ,python-2)))
     (arguments
-     '(#:phases
+     ;; FIXME: On armhf-linux, Subprocess.TestWithLots fails like this:
+     ;;   *** Failure in src/subprocess_test.cc:241
+     ;;   ExitSuccess == procs[i]->Finish()
+     ;; See <https://hydra.gnu.org/build/2515522/nixlog/1/raw>.
+     ;; Disable for now.
+     `(#:tests? (let ((system ,(or (%current-target-system)
+                                   (%current-system))))
+                  (not (string-prefix? "arm" system)))
+       #:phases
        (modify-phases %standard-phases
          (replace 'configure
            (lambda _
@@ -53,10 +61,12 @@
            (lambda _
              (invoke "./configure.py" "--bootstrap")))
          (replace 'check
-           (lambda _
-             (invoke "./configure.py")
-             (invoke "./ninja" "ninja_test")
-             (invoke "./ninja_test")))
+           (lambda* (#:key tests? #:allow-other-keys)
+             (if tests?
+                 (and (invoke "./configure.py")
+                      (invoke "./ninja" "ninja_test")
+                      (invoke "./ninja_test"))
+                 (display "test suite not run\n"))))
          (replace 'install
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))
-- 
2.16.2

             reply	other threads:[~2018-02-25  3:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-25  3:54 Marius Bakke [this message]
2018-02-26 17:49 ` [bug#30601] [PATCH staging] gnu: ninja: Disable tests on armhf Ludovic Courtès
2018-02-26 19:40   ` bug#30601: " Marius Bakke
2018-02-26 20:02     ` [bug#30601] " Marius Bakke
2018-02-27  9:05       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180225035438.24171-1-mbakke@fastmail.com \
    --to=mbakke@fastmail.com \
    --cc=30601@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).