From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1epf88-0005br-59 for guix-patches@gnu.org; Sat, 24 Feb 2018 14:05:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1epf83-00022S-PN for guix-patches@gnu.org; Sat, 24 Feb 2018 14:05:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:51125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1epf83-00022I-Kx for guix-patches@gnu.org; Sat, 24 Feb 2018 14:05:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1epf83-0003cR-C9 for guix-patches@gnu.org; Sat, 24 Feb 2018 14:05:03 -0500 Subject: [bug#30596] [PATCH 3/6] gnu: java-snappy: Update to 1.1.7. Resent-Message-ID: From: Marius Bakke Date: Sat, 24 Feb 2018 20:03:46 +0100 Message-Id: <20180224190349.8155-3-mbakke@fastmail.com> In-Reply-To: <20180224190349.8155-1-mbakke@fastmail.com> References: <20180224190349.8155-1-mbakke@fastmail.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 30596@debbugs.gnu.org * gnu/packages/compression.scm (java-snappy): Update to 1.1.7. [arguments]: Use INVOKE instead of SYSTEM*. Avoid CMAKE dependency. Delete Hadoop test. Enable fixed test. [native-inputs]: Add JAVA-COMMONS-LANG and JAVA-COMMONS-IO. --- gnu/packages/compression.scm | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index b7ae2b9ed..4e067c2a5 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -1132,7 +1132,7 @@ install: libbitshuffle.so (define-public java-snappy (package (name "java-snappy") - (version "1.1.4") + (version "1.1.7") (source (origin (method url-fetch) (uri (string-append "https://github.com/xerial/snappy-java/archive/" @@ -1140,7 +1140,7 @@ install: libbitshuffle.so (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "1w58diryma7qz7aa24yv8shf3flxcbbw8jgcn2lih14wgmww58ww")))) + "0q4kxz2n97czf6g5gzq0d8yz22cgiaj7wp51rzsswh3bi99bpgg5")))) (build-system ant-build-system) (arguments `(#:jar-name "snappy.jar" @@ -1180,7 +1180,9 @@ install: libbitshuffle.so (("NAME\\): \\$\\(SNAPPY_OBJ\\)") "NAME): $(SNAPPY_OBJ)\n\t@mkdir -p $(@D)")) ;; Finally we can run the Makefile to build the dynamic library. - (zero? (system* "make" "native")))) + ;; Use the -nocmake target to avoid a dependency on cmake, + ;; which in turn requires the "git_unpacked" directory. + (invoke "make" "native-nocmake"))) ;; Once we have built the shared library, we need to place it in the ;; "build" directory so it can be added to the jar file. (add-after 'build-jni 'copy-jni @@ -1189,13 +1191,14 @@ install: libbitshuffle.so "build/classes/org/xerial/snappy/native"))) (add-before 'check 'fix-failing (lambda _ - ;; This package assumes maven build, which puts results in "target". - ;; We put them in "build" instead, so fix that. - (substitute* "src/test/java/org/xerial/snappy/SnappyLoaderTest.java" - (("target/classes") "build/classes")) - ;; FIXME: probably an error - (substitute* "src/test/java/org/xerial/snappy/SnappyOutputStreamTest.java" - (("91080") "91013"))))))) + (with-directory-excursion "src/test/java/org/xerial/snappy" + ;; This package assumes maven build, which puts results in "target". + ;; We put them in "build" instead, so fix that. + (substitute* "SnappyLoaderTest.java" + (("target/classes") "build/classes")) + ;; This requires Hadoop, which is not in Guix yet. + (delete-file "SnappyHadoopCompatibleOutputStreamTest.java")) + #t))))) (inputs `(("osgi-framework" ,java-osgi-framework))) (propagated-inputs @@ -1206,6 +1209,8 @@ install: libbitshuffle.so ("hamcrest" ,java-hamcrest-core) ("xerial-core" ,java-xerial-core) ("classworlds" ,java-plexus-classworlds) + ("commons-lang" ,java-commons-lang) + ("commons-io" ,java-commons-io) ("perl" ,perl))) (home-page "https://github.com/xerial/snappy-java") (synopsis "Compression/decompression algorithm in Java") -- 2.16.2