[bug#30380] gnu: Add dolphin-emu.

["Björn Höfling" <bjoern.hoefling@bjoernhoefling.de>]

Hi Rutger,

On Fri, 16 Feb 2018 10:20:46 +0100
Rutger Helling <rhelling@mykolab.com> wrote:

> Hello everyone,
> 
> As promised I've updated these patches. Just to reiterate, these are
> David's patches. I've only changed a few things.
> 
> Here's the changes of the top of my head:
> * First patch is unchanged.
> * Renamed to dolphin-emu instead of dolphin-emulator since that seems
>   like a more canonical name.
> * Incorporated Björn's suggestions.
> * Added a few more inputs to get rid of more externals.
> * Enabled Qt interface.

Thanks for taking another iteration of this. 

In my review of the first patch by David I stated that I haven't done a
full review. I just mentioned some points I noticed, not all possible
critics. I still haven't done a full review and found some more points.

As Dave said, this package bears some "friction": I'm still not
convinced of it. For me this doesn't feel like a sound, perfect
package. It is a collection of the emulators code plus binaries plus
reverse-engineered codes and notes plus external documentation. 

I thought of quickly fixing it myself but I find it hard to
figure out what of the Data and the docs directory is really part of the
program (documentation) and what can safely be stripped away.

On the other hand there seams to be interest by at least 2-3 people to
make a package out of that and I wouldn't say it's not possible.

Here is what I found that should be stripped away:

/review/dolphin-emu-5.0-0.d04b179-checkout$ find . -name "*.rar" -or
-name "*.pdf" -or -name "*.bin" -or -name "*.pdf" -or -name "*.dsy" -or -name "*.jar" -or -name "*.exe" 

./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10001.bin
./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10000.bin
./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10000_strip.bin
./docs/WiiMote/Dumps/WiiMote_AttribTree_0x10001_strip.bin
./docs/WiiMote/Dumps/WiiMote_ServiceScan.bin
./docs/WiiMote/HID_SPEC_V10.rar
./docs/DSP/GC_DSP.pdf
./Installer/vcredist/vc_redist.x64.exe
./Source/Android/code-style-java.jar
./Source/Android/gradle/wrapper/gradle-wrapper.jar
./Data/Sys/Wii/shared2/wc24/nwc24dl.bin
./Data/Sys/Wii/shared2/wc24/misc.bin
./Data/Sys/Wii/shared2/wc24/nwc24fls.bin
./Data/Sys/Wii/shared2/wc24/nwc24fl.bin
./Data/Sys/GC/font_western.bin
./Data/Sys/GC/font_japanese.bin
./Data/Sys/totaldb.dsy
./Data/Sys/codehandler.bin


Yours,

Björn