unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#30514] [PATCH 0/1] Add minitube
@ 2018-02-18 14:59 Ricardo Wurmus
  2018-02-18 16:00 ` [bug#30514] [PATCH 1/1] gnu: " Ricardo Wurmus
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2018-02-18 14:59 UTC (permalink / raw)
  To: 30514; +Cc: Ricardo Wurmus

Hi Guix,

This patch adds minitube, an alternative way to browse Youtube.
I'm not really happy with this patch for three reasons:

1. it should really go to (gnu packages video), but I could not import (gnu
packages kde-frameworks) from that module.

2. The package requires extra setup on non-KDE systems.  To get Phonon to work
I had to install phonon-backend-gstreamer and set QT_PLUGIN_PATH to include
its lib/qt5/ directory.

3. Users need to obtain a Google API key before they can use the application.
This is a rather involved process and requires a Google account.

What do you think?

Ricardo Wurmus (1):
  gnu: Add minitube.

 gnu/packages/kde.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

-- 
2.16.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#30514] [PATCH 1/1] gnu: Add minitube.
  2018-02-18 14:59 [bug#30514] [PATCH 0/1] Add minitube Ricardo Wurmus
@ 2018-02-18 16:00 ` Ricardo Wurmus
  2018-02-19 15:44 ` [bug#30514] [PATCH 0/1] " Tobias Geerinckx-Rice
  2019-02-13  0:14 ` bug#30514: " Leo Famulari
  2 siblings, 0 replies; 4+ messages in thread
From: Ricardo Wurmus @ 2018-02-18 16:00 UTC (permalink / raw)
  To: 30514; +Cc: Ricardo Wurmus

* gnu/packages/kde.scm (minitube): New variable.
---
 gnu/packages/kde.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index 2ec5452a6..a419e5668 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -3,6 +3,7 @@
 ;;; Copyright © 2016, 2017 Thomas Danckaert <post@thomasdanckaert.be>
 ;;; Copyright © 2017 Mark Meyer <mark@ofosos.org>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me@tobias.gr>
+;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,7 +22,9 @@
 
 (define-module (gnu packages kde)
   #:use-module (guix build-system cmake)
+  #:use-module (guix build-system gnu)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
   #:use-module (guix utils)
@@ -509,3 +512,47 @@ cards.")
 Using a plugin system it is possible to create notifications with many
 different notification systems.")
     (license license:lgpl3)))
+
+(define-public minitube
+  (package
+    (name "minitube")
+    (version "2.9")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/flaviotordini/minitube.git")
+                    (commit version)))
+              (file-name (string-append name "-" version "-checkout"))
+              (sha256
+               (base32
+                "11zkmwqadlgrrghs3rxq0h0fllfnyd3g09d7gdd6vd9r1a1yz73f"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (replace 'configure
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (substitute* "minitube.pro"
+               (("/usr/include/phonon4qt5")
+                (string-append (assoc-ref inputs "phonon")
+                               "/include/phonon4qt5")))
+             (invoke "qmake"
+                     (string-append "QMAKE_LRELEASE="
+                                    (assoc-ref inputs "qttools")
+                                    "/bin/lrelease")
+                     (string-append "PREFIX="
+                                    (assoc-ref outputs "out")))
+             #t)))))
+    (native-inputs
+     `(("qttools" ,qttools)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)
+       ("phonon" ,phonon)))
+    (home-page "https://flavio.tordini.org/minitube")
+    (synopsis "YouTube browser application")
+    (description "Minitube is a YouTube desktop application.  Watch YouTube
+videos in a new way: you type a keyword, Minitube gives you an endless video
+stream.")
+    (license license:gpl3+)))
-- 
2.16.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#30514] [PATCH 0/1] Add minitube
  2018-02-18 14:59 [bug#30514] [PATCH 0/1] Add minitube Ricardo Wurmus
  2018-02-18 16:00 ` [bug#30514] [PATCH 1/1] gnu: " Ricardo Wurmus
@ 2018-02-19 15:44 ` Tobias Geerinckx-Rice
  2019-02-13  0:14 ` bug#30514: " Leo Famulari
  2 siblings, 0 replies; 4+ messages in thread
From: Tobias Geerinckx-Rice @ 2018-02-19 15:44 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 30514, Guix-patches

Ricardo,

On 2018-02-18 15:59, Ricardo Wurmus wrote:
> This patch adds minitube, an alternative way to browse Youtube.
> I'm not really happy with this patch for three reasons:

[...]

> 3. Users need to obtain a Google API key before they can use the 
> application.

Not necessarily. I ‘solved’ this in Nix[0] by creating my own key and 
sharing it with the world, of the opinion that these keys are in fact 
intended for distributors, not users or authors. Like ntp.org pools. 
It's also trivial for a user to pass their own key if they so desire.

> This is a rather involved process and requires a Google account.

I don't remember how involved it was, but I have long since lost the 
credentials to my account. Either the associated key is still valid 
after 3 years, or nobody uses Minitube from Nix. Both seem about equally 
likely. :-)

Just pointing out that it's possible. I don't believe this jives with 
Guix's stated goal of user empowerment. If they want to experience 
YouTube, don't let's sugar-coat the pill.

T G-R

Sent from a Web browser. Excuse or enjoy my brevity, or, in this mail, 
not so much.

[0]: 
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/video/minitube/default.nix

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#30514: [PATCH 0/1] Add minitube
  2018-02-18 14:59 [bug#30514] [PATCH 0/1] Add minitube Ricardo Wurmus
  2018-02-18 16:00 ` [bug#30514] [PATCH 1/1] gnu: " Ricardo Wurmus
  2018-02-19 15:44 ` [bug#30514] [PATCH 0/1] " Tobias Geerinckx-Rice
@ 2019-02-13  0:14 ` Leo Famulari
  2 siblings, 0 replies; 4+ messages in thread
From: Leo Famulari @ 2019-02-13  0:14 UTC (permalink / raw)
  To: Ricardo Wurmus; +Cc: 30514-done

Due to the lack of activity on this patch I'm closing the bug.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-13  0:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-18 14:59 [bug#30514] [PATCH 0/1] Add minitube Ricardo Wurmus
2018-02-18 16:00 ` [bug#30514] [PATCH 1/1] gnu: " Ricardo Wurmus
2018-02-19 15:44 ` [bug#30514] [PATCH 0/1] " Tobias Geerinckx-Rice
2019-02-13  0:14 ` bug#30514: " Leo Famulari

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).