From: Danny Milosavljevic <dannym@scratchpost.org>
To: 30498@debbugs.gnu.org
Subject: [bug#30498] [PATCH shepherd] shepherd: If /dev/kmsg is writable, use it for logging.
Date: Sat, 17 Feb 2018 13:20:35 +0100 [thread overview]
Message-ID: <20180217122035.1443-1-dannym@scratchpost.org> (raw)
* modules/shepherd.scm (main): If /dev/kmsg is used, don't log to console
again - use only /dev/kmsg.
* modules/shepherd/comm.scm (%current-logfile-date-format): New variable.
(make-shepherd-output-port): Use it. Export.
* modules/shepherd/support.scm (default-logfile-date-format): New variable.
(default-logfile): Use /dev/kmsg if writable.
(default-logfile-date-format): Drop duplicate timestamp.
---
modules/shepherd.scm | 6 +++++-
modules/shepherd/comm.scm | 11 ++++++-----
modules/shepherd/support.scm | 11 ++++++++++-
3 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/modules/shepherd.scm b/modules/shepherd.scm
index 5334657..2db56a1 100644
--- a/modules/shepherd.scm
+++ b/modules/shepherd.scm
@@ -141,8 +141,12 @@
;; Enable logging as first action.
(start-logging logfile)
+ (if (string=? logfile "/dev/kmsg")
+ ;; Prevent duplicate messages.
+ (set-current-output-port (%make-void-port "w")))
+
;; Send output to log and clients.
- (set-current-output-port shepherd-output-port)
+ (set-current-output-port (make-shepherd-output-port (current-output-port)))
;; Start the 'root' service.
(start root-service)
diff --git a/modules/shepherd/comm.scm b/modules/shepherd/comm.scm
index 0228f63..6cea6f0 100644
--- a/modules/shepherd/comm.scm
+++ b/modules/shepherd/comm.scm
@@ -51,7 +51,8 @@
start-logging
stop-logging
%current-client-socket
- shepherd-output-port))
+ %current-logfile-date-format
+ make-shepherd-output-port))
\f
;; Command for shepherd.
@@ -200,6 +201,9 @@ on service '~a':")
;; Socket of the client currently talking to the daemon.
(make-parameter #f))
+(define %current-logfile-date-format
+ (make-parameter default-logfile-date-format))
+
;; We provide our own output mechanism, because we have certain
;; special needs; most importantly, we want to send output to herd
;; sometimes.
@@ -228,7 +232,7 @@ on service '~a':")
(let* ((log (lambda (x)
(display x log-output-port)))
(init-line (lambda ()
- (log (strftime "%Y-%m-%d %H:%M:%S "
+ (log (strftime (%current-logfile-date-format)
(localtime (current-time)))))))
(init-line)
(for-each log (reverse buffer))
@@ -259,6 +263,3 @@ on service '~a':")
;; It's an output-only port.
"w"))
-
-(define shepherd-output-port
- (make-shepherd-output-port (current-output-port)))
diff --git a/modules/shepherd/support.scm b/modules/shepherd/support.scm
index bb01edc..585aef9 100644
--- a/modules/shepherd/support.scm
+++ b/modules/shepherd/support.scm
@@ -22,6 +22,7 @@
(define-module (shepherd support)
#:use-module (shepherd config)
#:use-module (ice-9 match)
+ #:use-module (ice-9 format)
#:export (call/ec
caught-error
assert
@@ -43,6 +44,7 @@
user-homedir
default-logfile
+ default-logfile-date-format
default-config-file
default-socket-dir
default-socket-file
@@ -282,9 +284,16 @@ TARGET should be a string representing a filepath + name."
;; Logfile.
(define default-logfile
(if (zero? (getuid))
- (string-append %localstatedir "/log/shepherd.log")
+ (if (access? "/dev/kmsg" W_OK)
+ "/dev/kmsg"
+ (string-append %localstatedir "/log/shepherd.log"))
(string-append %user-config-dir "/shepherd.log")))
+(define default-logfile-date-format
+ (if (and (zero? (getuid)) (string=? default-logfile "/dev/kmsg"))
+ (format #f "shepherd[~d]: " (getpid))
+ "%Y-%m-%d %H:%M:%S "))
+
;; Configuration file.
(define (default-config-file)
"Return the default configuration file---either the user's file, or the
next reply other threads:[~2018-02-17 12:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-17 12:20 Danny Milosavljevic [this message]
2018-02-17 12:25 ` [bug#30498] [PATCH shepherd] shepherd: If /dev/kmsg is writable, use it for logging Danny Milosavljevic
2018-02-17 16:48 ` [bug#30498] [WIP v2 " Danny Milosavljevic
2018-02-17 16:49 ` Danny Milosavljevic
2018-02-26 18:04 ` Ludovic Courtès
2018-02-26 21:51 ` Danny Milosavljevic
2018-02-27 9:22 ` Ludovic Courtès
2018-02-26 22:32 ` Danny Milosavljevic
2018-02-27 9:19 ` Ludovic Courtès
2018-03-03 21:54 ` Ludovic Courtès
2018-03-03 22:37 ` Danny Milosavljevic
2018-03-05 16:51 ` Ludovic Courtès
2018-03-06 8:09 ` Danny Milosavljevic
2018-03-07 12:46 ` Ludovic Courtès
2018-03-07 11:04 ` [bug#30498] [PATCH 0/3] Log to syslog whenever possible Ludovic Courtès
2018-03-07 11:04 ` [bug#30498] [PATCH 1/3] Turn 'log-output-port' into a parameter Ludovic Courtès
2018-03-07 11:04 ` [bug#30498] [PATCH 2/3] Simplify 'make-shepherd-output-port' Ludovic Courtès
2018-03-07 11:04 ` [bug#30498] [PATCH 3/3] Use syslog for logging when running as root Ludovic Courtès
2018-03-07 15:25 ` [bug#30498] [PATCH 0/3] Log to syslog whenever possible Ludovic Courtès
2018-03-15 17:00 ` bug#30498: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180217122035.1443-1-dannym@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=30498@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).