From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36171)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1emLfi-0005Yr-J1
	for guix-patches@gnu.org; Thu, 15 Feb 2018 10:42:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1emLfe-000405-KN
	for guix-patches@gnu.org; Thu, 15 Feb 2018 10:42:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:37095)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1emLfe-0003zg-Fo
	for guix-patches@gnu.org; Thu, 15 Feb 2018 10:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1emLfe-0008Np-0N
	for guix-patches@gnu.org; Thu, 15 Feb 2018 10:42:02 -0500
Subject: [bug#30464] [PATCH 1/2] services: Add console-agetty-service.
Resent-Message-ID: <handler.30464.B30464.151870930232196@debbugs.gnu.org>
Date: Thu, 15 Feb 2018 16:41:35 +0100
From: Danny Milosavljevic <dannym@scratchpost.org>
Message-ID: <20180215164135.188beed0@scratchpost.org>
In-Reply-To: <87r2pm8gfl.fsf@gnu.org>
References: <20180215114256.551-1-dannym@scratchpost.org>
	<20180215114742.663-1-dannym@scratchpost.org>
	<87r2pm8gfl.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 30464@debbugs.gnu.org

Hi Ludo,

On Thu, 15 Feb 2018 15:40:14 +0100
ludo@gnu.org (Ludovic Court=C3=A8s) wrote:

> Could you explain the rationale?
>=20
> The only difference is that this shepherd service depends on =E2=80=98sys=
logd=E2=80=99
> whereas the current agetty service doesn=E2=80=99t, right?

Yes, it's my inner OCD.

Right now, the agetty is started while the Linux kernel is still booting and
printing stuff to the console.  So you have two parties printing stuff
to the same console simultaneously.  That looks ... not nice.

What this would do is the getty would only be started (and printing stuff)
after syslogd.  The first thing syslogd does is it disables the Linux direct
console printing.

It doesn't make sense to have agetty itself depend on syslogd because
agetty can be (and usually is) used for modems etc which have nothing
to do with the local console.

> > +(define* (console-agetty-service config)
> > +  "Return a service to run agetty according to @var{config}, which spe=
cifies
> > +the tty to run, defaulting to the Linux console."
> > +  (service console-agetty-service-type config)) =20
>=20
> In general we don=E2=80=99t provide such procedures any more and instead =
expose
> service types and configs directly.

Okay, I can remove that one and inline it at the (only) call site.