From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1elhK5-0007pM-QG for guix-patches@gnu.org; Tue, 13 Feb 2018 15:37:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1elhK2-0006cb-OG for guix-patches@gnu.org; Tue, 13 Feb 2018 15:37:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33944) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1elhK2-0006cT-JY for guix-patches@gnu.org; Tue, 13 Feb 2018 15:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1elhK2-0001HP-AP for guix-patches@gnu.org; Tue, 13 Feb 2018 15:37:02 -0500 Subject: [bug#30446] [PATCH 2/3] gnu: Add intelmetool. Resent-Message-ID: Date: Tue, 13 Feb 2018 21:36:26 +0100 From: Danny Milosavljevic Message-ID: <20180213213626.7d3a7910@scratchpost.org> In-Reply-To: <20180213192031.GB31517@jasmine.lan> References: <20180213180001.4339-1-dannym@scratchpost.org> <20180213180145.4412-1-dannym@scratchpost.org> <20180213180145.4412-2-dannym@scratchpost.org> <20180213192031.GB31517@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30446@debbugs.gnu.org Hi Leo, > Overall LGTM, but I don't think we should use the description as a > source of copy-and-paste instructions. Does the package include any > docs? Apparently not. While coreboot has docs, it doesn't mention intelmetool anywhere. I just thought to include those things in the description because if you don't do the stuff (note: Guix doesn't do it by default) it will fail in strange ways (and did for me).