From: Leo Famulari <leo@famulari.name>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 30446@debbugs.gnu.org
Subject: [bug#30446] [PATCH 2/3] gnu: Add intelmetool.
Date: Tue, 13 Feb 2018 14:20:31 -0500 [thread overview]
Message-ID: <20180213192031.GB31517@jasmine.lan> (raw)
In-Reply-To: <20180213180145.4412-2-dannym@scratchpost.org>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Tue, Feb 13, 2018 at 07:01:44PM +0100, Danny Milosavljevic wrote:
> * gnu/packages/flashing-tools.scm (intelmetool): New variable.
> +(define-public intelmetool
> + (let ((commit "1b64ae1119fc7891b043d5d29bf93859ef9dbfa1")
> + (revision "0"))
> + (package
> + (name "intelmetool")
> + (version (git-version "0.0" revision commit))
Same feedback about the version string as with the other coreboot-based
package.
> + (synopsis "Intel ME tools")
> + (description "This package provides tools for working with Intel
> +Management Engine (ME). You need to @code{sudo rmmod mei_me} and
> +@code{sudo rmmod mei} before using this tool. Also pass
> +@code{iomem=relaxed} to the Linux kernel command line.")
Overall LGTM, but I don't think we should use the description as a
source of copy-and-paste instructions. Does the package include any
docs?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-13 19:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 18:00 [bug#30446] [PATCH 0/3] Add Intel ME tools Danny Milosavljevic
2018-02-13 18:01 ` [bug#30446] [PATCH 1/3] gnu: Add ifdtool Danny Milosavljevic
2018-02-13 18:01 ` [bug#30446] [PATCH 2/3] gnu: Add intelmetool Danny Milosavljevic
2018-02-13 19:20 ` Leo Famulari [this message]
2018-02-13 20:36 ` Danny Milosavljevic
2018-02-14 3:06 ` Leo Famulari
2018-02-13 18:01 ` [bug#30446] [PATCH 3/3] gnu: Add me-cleaner Danny Milosavljevic
2018-02-13 19:21 ` Leo Famulari
2018-02-13 21:29 ` Danny Milosavljevic
2018-02-13 19:18 ` [bug#30446] [PATCH 1/3] gnu: Add ifdtool Leo Famulari
2018-02-13 20:37 ` Danny Milosavljevic
2018-02-13 21:50 ` Marius Bakke
2018-02-14 3:00 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213192031.GB31517@jasmine.lan \
--to=leo@famulari.name \
--cc=30446@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).