From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37290) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1el1BD-0002WB-JC for guix-patches@gnu.org; Sun, 11 Feb 2018 18:37:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1el1B8-0008VC-IN for guix-patches@gnu.org; Sun, 11 Feb 2018 18:37:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:59066) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1el1B8-0008U6-Cy for guix-patches@gnu.org; Sun, 11 Feb 2018 18:37:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1el1B7-0004Js-Vl for guix-patches@gnu.org; Sun, 11 Feb 2018 18:37:02 -0500 Subject: [bug#30417] [PATCH 01/11] gnu: Add java-plexus-component-annotations. Resent-Message-ID: Date: Mon, 12 Feb 2018 00:36:01 +0100 From: =?UTF-8?Q?Bj=C3=B6rn_?= =?UTF-8?Q?H=C3=B6fling?= Message-ID: <20180212003601.494e2979@alma-ubu> In-Reply-To: <20180210230438.26794-1-julien@lepiller.eu> References: <20180210234811.40ddec07@lepiller.eu> <20180210230438.26794-1-julien@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 30417@debbugs.gnu.org On Sun, 11 Feb 2018 00:04:28 +0100 Julien Lepiller wrote: > * gnu/packages/java.scm (java-plexus-component-annotations): New > variable. > --- > gnu/packages/java.scm | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm > index e714a031c..b7f3fd54e 100644 > --- a/gnu/packages/java.scm > +++ b/gnu/packages/java.scm > @@ -2662,6 +2662,17 @@ archives (jar).") > `(("archiver" ,java-plexus-archiver) > ("hamcrest" ,java-hamcrest-core))))) > =20 > +(define-public java-plexus-component-annotations > + (package > + (inherit java-plexus-container-default) > + (name "java-plexus-component-annotations") > + (arguments > + `(#:jar-name "plexus-component-annotations.jar" > + #:source-dir "plexus-component-annotations/src/main/java" > + #:tests? #f)); no tests > + (inputs '()) > + (native-inputs '()))) > + > (define-public java-asm > (package > (name "java-asm") * This one inherits java-plexus-container-default, but does not adapt synopsis/description. Is that OK? * Sorry for being so late, but I also looked into the java-plexus-container-default-bootstrap: It contains some jar's in the test path. Is that OK? find . -name "*.jar" ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-a-2.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/plexus-archiver-1.0-alpha-8.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-c-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/plugin1-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-b-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/component-a-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/test-components/plugin0-1.0-SNAPSHOT.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/c.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/b.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/d.jar ./plexus-containers-plexus-containers-1.7.1/plexus-container-default/src/te= st/resources/jar-repository/a.jar * We have a java-plexus-container-default and java-plexus-container-default-bootstrap. Both are "define-public". Should we make the bootstrap non-public? Otherwise, LGTM. And even though I have my comments, thanks for all this awesome Java/Maven work! Bj=C3=B6rn